Repository navigation
wasmtime: update to v0.30.0. - #194
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
0865b88 to
f152086
Compare
|
Signed-off-by: Ryan Northey <ryan@synca.io>
588a3ef to
852223d
Compare
|
thanks, updated |
PiotrSikora
left a comment
There was a problem hiding this comment.
You need to bump versions to v0.30.0 in bazel/cargo/Cargo.toml and regenerate crates again.
|
thanks, i updated again i had to remove the path from the |
wasmtime -> 0.30.0|
@PiotrSikora not sure how to resolve the error in CI i bumped the grepping, and looking at the log failure it seems like there is a bazel dependency on version |
PiotrSikora
left a comment
There was a problem hiding this comment.
grepping, and looking at the log failure it seems like there is a bazel dependency on version 0.19.0 - not sure if that is related
0.19.0 is the version of wasmtime-c-api-macros crate, but it's not published, so we're downloading it from wasmtime's repo.
| once_cell = "1.3" | ||
| wasmtime = {version = "0.26.0", default-features = false} | ||
| wasmtime-c-api-macros = {git = "https://github.com/bytecodealliance/wasmtime", tag = "v0.26.0", path = "crates/c-api/macros"} | ||
| wasmtime = {version = "0.30.0", default-features = false} |
There was a problem hiding this comment.
You need to add , features = ['cranelift'] in wasmtime dependency (that's new in v0.30.0 and I ended up diffing changes in wasmtime to figure it out...). Once you regenerate crates (again), it should work fine.
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
b9a99f0 to
11a6505
Compare
|
updated and regenerated lockfile - force-pushed to fix DCO |
PiotrSikora
left a comment
There was a problem hiding this comment.
Could you update the package version from 0.25.0 to 0.30.0 in bazel/cargo/Cargo.toml as well? Thanks!
Signed-off-by: Ryan Northey <ryan@synca.io>
|
It looks that Cranelift needs a more recent version of Rust. See: #195. |
is that in CI/repo - or my local version? I think i have a pretty recent version locally, so im guessing the former |
|
Both, since Bazel is using Rust version from |
attempting to update wasmtime in Envoy main (cf envoyproxy/envoy#18499 (review))
not sure how to regenerate crates