Skip to content

wasmtime: update to v0.30.0. - #194

Merged
PiotrSikora merged 6 commits into
proxy-wasm:masterfrom
phlax:deps-bump-wasmtime
Oct 18, 2021
Merged

PiotrSikora merged 6 commits into
proxy-wasm:masterfrom
phlax:deps-bump-wasmtime

Conversation

@phlax

@phlax phlax commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

attempting to update wasmtime in Envoy main (cf envoyproxy/envoy#18499 (review))

not sure how to regenerate crates

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
phlax force-pushed the deps-bump-wasmtime branch from 0865b88 to f152086 Compare October 7, 2021 16:31
@PiotrSikora

Copy link
Copy Markdown
Member

not sure how to regenerate crates

cd bazel/cargo
cargo install cargo-raze --version 0.12.0
cargo raze --generate-lockfile
git add .

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
phlax force-pushed the deps-bump-wasmtime branch from 588a3ef to 852223d Compare October 7, 2021 16:52
@phlax

phlax commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

thanks, updated

@PiotrSikora PiotrSikora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump versions to v0.30.0 in bazel/cargo/Cargo.toml and regenerate crates again.

@phlax

phlax commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

thanks, i updated again

i had to remove the path from the wasmtime-c-api-macros dependency - not sure if this is due to my cargo version changing

@PiotrSikora PiotrSikora changed the title deps: Bump wasmtime -> 0.30.0 wasmtime: update to v0.30.0. Oct 14, 2021
@phlax

phlax commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

@PiotrSikora not sure how to resolve the error in CI

i bumped the wasmtime-c-api-macros dep in Cargo.toml in line with the change to the wasmtime version

grepping, and looking at the log failure it seems like there is a bazel dependency on version 0.19.0 - not sure if that is related

@PiotrSikora PiotrSikora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grepping, and looking at the log failure it seems like there is a bazel dependency on version 0.19.0 - not sure if that is related

0.19.0 is the version of wasmtime-c-api-macros crate, but it's not published, so we're downloading it from wasmtime's repo.

Comment thread bazel/cargo/Cargo.toml Outdated
once_cell = "1.3"
wasmtime = {version = "0.26.0", default-features = false}
wasmtime-c-api-macros = {git = "https://github.com/bytecodealliance/wasmtime", tag = "v0.26.0", path = "crates/c-api/macros"}
wasmtime = {version = "0.30.0", default-features = false}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add , features = ['cranelift'] in wasmtime dependency (that's new in v0.30.0 and I ended up diffing changes in wasmtime to figure it out...). Once you regenerate crates (again), it should work fine.

phlax added 2 commits October 15, 2021 18:54
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
phlax force-pushed the deps-bump-wasmtime branch from b9a99f0 to 11a6505 Compare October 15, 2021 17:54
@phlax

phlax commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

updated and regenerated lockfile - force-pushed to fix DCO

@PiotrSikora PiotrSikora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the package version from 0.25.0 to 0.30.0 in bazel/cargo/Cargo.toml as well? Thanks!

Signed-off-by: Ryan Northey <ryan@synca.io>
@PiotrSikora

Copy link
Copy Markdown
Member

It looks that Cranelift needs a more recent version of Rust. See: #195.

@phlax

phlax commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

It looks that Cranelift needs a more recent version of Rust

is that in CI/repo - or my local version?

I think i have a pretty recent version locally, so im guessing the former

@PiotrSikora

Copy link
Copy Markdown
Member

Both, since Bazel is using Rust version from rules_rust. #195 resolves the issue (confirmed locally), so we just need to wait until it's approved and merged to rebase this PR and fix the CI.

@PiotrSikora PiotrSikora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants