Skip to content

deps: bump com_github_wasmtime -> 1.0.0 - #23232

Merged
mattklein123 merged 1 commit into
envoyproxy:mainfrom
RiverPhillips:wasmtime-1.0.0
Sep 26, 2022
Merged

mattklein123 merged 1 commit into
envoyproxy:mainfrom
RiverPhillips:wasmtime-1.0.0

Conversation

@RiverPhillips

Copy link
Copy Markdown
Contributor

Commit Message: deps: bump com_github_wasmtime -> 1.0.0
Additional Description: Resolves #23193
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: river phillips <riverphillips1@gmail.com>
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Sep 23, 2022
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #23232 was opened by RiverPhillips.

see: more, trace.

@phlax

phlax commented Sep 23, 2022

Copy link
Copy Markdown
Member

cc @kfaseela

@moderation

Copy link
Copy Markdown
Contributor

/lgtm deps

This looks like it is passing without some of the normal adjacent dependency updates

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 24, 2022
@mattklein123
mattklein123 merged commit 0c6de85 into envoyproxy:main Sep 26, 2022
@phlax

phlax commented Sep 26, 2022

Copy link
Copy Markdown
Member

This looks like it is passing without some of the normal adjacent dependency updates

not sure it that is cause for concern cc @PiotrSikora

@PiotrSikora

Copy link
Copy Markdown
Contributor

Wasmtime (well, it's Bazel rules) is tracked and updated in Proxy-Wasm C++ Host. The only thing updated in this PR are the C API files used in bazel/external/wasmtime.BUILD, but @proxy_wasm_cpp_host//bazel/cargo/wasmtime dependency there still points at Wasmtime v0.39.1.

Tests passed, because the C API didn't change between v0.39.1 and v1.0.0, but this PR didn't update Wasmtime.

It might be worth documenting this somewhere in bazel/repository_locations.bzl. cc @mpwarres

@kfaseela

Copy link
Copy Markdown
Contributor

@RiverPhillips Will you be interested in pushing the corresponding PR in Proxy-Wasm C++ Host ? Some info on how to do the update can be seen at proxy-wasm/proxy-wasm-cpp-host#194 (comment)

@RiverPhillips

Copy link
Copy Markdown
Contributor Author

Sure @kfaseela will have a look

phlax pushed a commit to phlax/envoy that referenced this pull request Nov 19, 2022
Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Nov 21, 2022
Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Nov 30, 2022
…24089)

* deps: bump `com_github_wasmtime` -> 1.0.0 (#23232)

Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>

* wasm: update WAVM to nightly/2022-05-14. (#22491)


Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>

* wasm: update Proxy-Wasm C++ Host to latest. (#22575)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>

* deps: Bump `com_github_wasmtime` -> 1.0.2 (#24086)

Fix:

- CVE-2022-39392
- CVE-2022-39393
- CVE-2022-39394

Signed-off-by: Ryan Northey <ryan@synca.io>

* bazel: update rules_rust

This gets us on rust 1.60

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: Ryan Northey <ryan@synca.io>

* deps: Bump `rules_rust` -> 0.8.1 (#22253)

Fix #22073

Signed-off-by: Ryan Northey <ryan@synca.io>

* wasm: fix V8 build on older versions of Linux. (#22228)

wasm: fix build on older versions of Linux.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>

* backport: macOS: Allow to load .wasm on Apple silicon (#23299)

backport: macOS: Enable wasm and allow to load .wasm on Apple silicon

This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for
MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages.

This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243)
on Apple silicon.

This is cherry-picked from: 63f27a6

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Ryan Northey <ryan@synca.io>

* deps: Bump `v8` to 10.7.193.13 and `proxy_wasm_cpp_host` to b0a0594 (#23434)

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

* ci: Disable wasm coverage tests (#24169)

and adjust-coverage-total

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>

* deps: Bump `com_github_wasmtime` -> 2.0.2 (+related) (#24150)

deps: Bump `com_github_wasmtime` -> 2.0.2

- `proxy_wasm_cpp_host`
- `proxy_wasm_rust_sdk`

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: phlax <phlax@users.noreply.github.com>
Co-authored-by: River <6375745+RiverPhillips@users.noreply.github.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Co-authored-by: Dhi Aurrahman <dio@rockybars.com>
phlax pushed a commit that referenced this pull request Dec 3, 2022
Signed-off-by: river phillips <riverphillips1@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available com_github_wasmtime: v1.0.0 (current: v0.39.1)

6 participants