Repository navigation
backport: macOS: Allow to load .wasm on Apple silicon - #23299
Merged
Merged
Conversation
This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages. This mainly affects macOS > 11.2 due to mprotect behavior changes (envoyproxy#23243) on Apple silicon. This is cherry-picked from: envoyproxy@63f27a6 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Member
Author
|
cc. @wbpcode |
RyanTheOptimist
approved these changes
Sep 29, 2022
repokitteh-read-only
Bot
removed
the
deps
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/assign @lizan |
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Nov 23, 2022
backport: macOS: Enable wasm and allow to load .wasm on Apple silicon This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages. This mainly affects macOS > 11.2 due to mprotect behavior changes (envoyproxy#23243) on Apple silicon. This is cherry-picked from: envoyproxy@63f27a6 Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Nov 24, 2022
backport: macOS: Enable wasm and allow to load .wasm on Apple silicon This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages. This mainly affects macOS > 11.2 due to mprotect behavior changes (envoyproxy#23243) on Apple silicon. This is cherry-picked from: envoyproxy@63f27a6 Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Nov 26, 2022
backport: macOS: Enable wasm and allow to load .wasm on Apple silicon This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages. This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243) on Apple silicon. This is cherry-picked from: 63f27a6 Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Nov 30, 2022
…24089) * deps: bump `com_github_wasmtime` -> 1.0.0 (#23232) Signed-off-by: river phillips <riverphillips1@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io> * wasm: update WAVM to nightly/2022-05-14. (#22491) Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io> * wasm: update Proxy-Wasm C++ Host to latest. (#22575) Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io> * deps: Bump `com_github_wasmtime` -> 1.0.2 (#24086) Fix: - CVE-2022-39392 - CVE-2022-39393 - CVE-2022-39394 Signed-off-by: Ryan Northey <ryan@synca.io> * bazel: update rules_rust This gets us on rust 1.60 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io> * deps: Bump `rules_rust` -> 0.8.1 (#22253) Fix #22073 Signed-off-by: Ryan Northey <ryan@synca.io> * wasm: fix V8 build on older versions of Linux. (#22228) wasm: fix build on older versions of Linux. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io> * backport: macOS: Allow to load .wasm on Apple silicon (#23299) backport: macOS: Enable wasm and allow to load .wasm on Apple silicon This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages. This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243) on Apple silicon. This is cherry-picked from: 63f27a6 Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Ryan Northey <ryan@synca.io> * deps: Bump `v8` to 10.7.193.13 and `proxy_wasm_cpp_host` to b0a0594 (#23434) Signed-off-by: Dhi Aurrahman <dio@rockybars.com> * ci: Disable wasm coverage tests (#24169) and adjust-coverage-total Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com> * deps: Bump `com_github_wasmtime` -> 2.0.2 (+related) (#24150) deps: Bump `com_github_wasmtime` -> 2.0.2 - `proxy_wasm_cpp_host` - `proxy_wasm_rust_sdk` Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: river phillips <riverphillips1@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: phlax <phlax@users.noreply.github.com> Co-authored-by: River <6375745+RiverPhillips@users.noreply.github.com> Co-authored-by: Piotr Sikora <piotrsikora@google.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com> Co-authored-by: Dhi Aurrahman <dio@rockybars.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages.
This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243) on Apple silicon.
This is cherry-picked from: 63f27a6
Signed-off-by: Dhi Aurrahman dio@rockybars.com
Risk Level: N/A
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: macOS