Skip to content

dep: update com_github_wasmtime: v0.32.0 (current: v0.31.0) - #19285

Merged
lizan merged 3 commits into
envoyproxy:mainfrom
Nordix:update-wasmtime
Jan 3, 2022
Merged

dep: update com_github_wasmtime: v0.32.0 (current: v0.31.0)#19285
lizan merged 3 commits into
envoyproxy:mainfrom
Nordix:update-wasmtime

Conversation

@kfaseela

@kfaseela kfaseela commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Faseela K faseela.k@est.tech

Fixes #19279

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Dec 14, 2021
@repokitteh-read-only

repokitteh-read-only Bot commented Dec 14, 2021

Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #19285 was opened by kfaseela.

see: more, trace.

@moderation

moderation commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

/lgtm deps

Dependency updates look OK but CI failures look real. You might need some of the WASM experts to chime in on what changed between releases - https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md#0320

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 15, 2021
@phlax

phlax commented Dec 15, 2021

Copy link
Copy Markdown
Member

cc @PiotrSikora

@PiotrSikora

PiotrSikora commented Dec 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Wasmtime update requires changes in Proxy-Wasm, please look at the previous updates:

@kfaseela

kfaseela commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Wasmtime update requires changes in Proxy-Wasm, please look at the previous updates:

Thanks for the info @PiotrSikora . Will wait for the proxy-wasm update then. I couldn't see a corresponding commit for 0.32.0 there.

@PiotrSikora

PiotrSikora commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

@kfaseela you pretty much need to do the update yourself, but it's pretty easy (sans breaking changes) and there are instructions in the PRs referenced above.

@kfaseela kfaseela mentioned this pull request Dec 23, 2021
Merged
@kfaseela
dep: update com_github_wasmtime: v0.32.0 (current: v0.31.0)
dc73ef8 
Signed-off-by: Faseela K <faseela.k@est.tech>
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Dec 31, 2021
@kfaseela
update proxy-wasm-cpp-host
ad53444 
Signed-off-by: Faseela K <faseela.k@est.tech>
PiotrSikora
PiotrSikora reviewed Jan 2, 2022
View reviewed changes
Comment thread bazel/repository_locations.bzl Outdated
version = "f38347360feaaf5b2a733f219c4d8c9660d626f0",
sha256 = "bf10de946eb5785813895c2bf16504afc0cd590b9655d9ee52fb1074d0825ea3",
version = "ab742cd64f9839e70dd194581e193dadf158928a",
sha256 = "0f721d7fd897ed904acfbcfccd43d1a79567084d8234c210e11c370226b0d702",

@PiotrSikora PiotrSikora Jan 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this to the merged commit? Thanks!

@kfaseela kfaseela Jan 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiotrSikora : Do I have to wait for #209 to be merged?

@PiotrSikora PiotrSikora Jan 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't matter, since we're updating the tarball that's updated in proxy-wasm/proxy-wasm-cpp-host#209 in this PR.

@kfaseela
Point proxy_wasm_cpp_host to the merged commit id
a2cbd3e 
Signed-off-by: Faseela K <faseela.k@est.tech>
PiotrSikora
PiotrSikora approved these changes Jan 3, 2022
View reviewed changes

@PiotrSikora PiotrSikora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@moderation

moderation commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 3, 2022
@lizan
lizan merged commit 04f48a2 into envoyproxy:main Jan 3, 2022
@kfaseela
kfaseela deleted the update-wasmtime branch January 13, 2022 16:23
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
@kfaseela Josh Perry
dep: update com_github_wasmtime: v0.32.0 (current: v0.31.0) (envoypro…
9e7354e 
…xy#19285)

Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@PiotrSikora PiotrSikora PiotrSikora approved these changes
@lizan lizan lizan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@PiotrSikora PiotrSikora

@moderation moderation

@phlax phlax

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Newer release available com_github_wasmtime: v0.32.0 (current: v0.31.0)

5 participants

@kfaseela @moderation @phlax @PiotrSikora @lizan