test(BA-7843): add scenario tests for the runtime variant adapter - #14535
Draft
jopemachine wants to merge 3 commits into
Draft
test(BA-7843): add scenario tests for the runtime variant adapter#14535jopemachine wants to merge 3 commits into
jopemachine wants to merge 3 commits into
Conversation
Fill adapters/runtime_variant/KNOWLEDGE.md with the scenarios the adapter guarantees and transcribe it into tests/scenario/bai_scenario/manager/runtime_variant/ — 29 rows over five modules. components/system.py is the caller-only situation every system concern table shares; the sibling PRs carry the same file byte for byte. The report is generated from CI run 34558080395. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
jopemachine
force-pushed
the
test/BA-7843-runtime-variant-scenarios
branch
from
September 11, 2026 04:09
ad5f485 to
1284270
Compare
This was referenced Sep 11, 2026
…arios for readability The knowledge document, the component docstrings and every scenario sentence used a terse, metaphorical style (문, 줄, 훑기, 심다, 실리다, 해석, 배선) that did not read at a glance. Rewrite them in plain technical Korean: 생성/조회/검색/수정/삭제 for the operations, 이름을 id로 변환 for resolve, 권한 검사 for enforcement, 미리 만들어 둔 for seeded data, Arabic numerals for the page sizes, and 역할 부족으로 거부 for the role refusals. report.md follows from the CI run in the next commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NQiEEB2mfJtFWnMnHLDFnT
jopemachine
added a commit
that referenced
this pull request
Sep 11, 2026
…et scenarios for readability The knowledge document, the component docstrings and every scenario sentence used a terse, metaphorical style (문, 줄, 훑기, 심다, 실리다, 배선) that did not read at a glance. Rewrite them in plain technical Korean: 생성/조회/검색/수정/삭제 for the operations, 권한 검사 for enforcement, 미리 만들어 둔 for seeded data, Arabic numerals for the order gap and page sizes, and 역할 부족으로 거부 for the role refusals. The shared runtime_variant component carries the same rewrite as #14535. report.md follows from the CI run in the next commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NQiEEB2mfJtFWnMnHLDFnT
…ten wording Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013qjgCzggSejnvDrLt4tG3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves BA-7843
Summary
api/adapters/runtime_variant/KNOWLEDGE.mdwith the scenarios the adapter guarantees, following the shapeapi/adapters/domain/KNOWLEDGE.mdset in test(BA-7779): PoC of scenario-table tests through the adapter layer #14448, and transcribe it intotests/scenario/bai_scenario/manager/runtime_variant/— 29 rows over five modules (creating, reading, searching, editing, retiring) — withseeds/runtime_variant/runtime_variant.pyandcomponents/runtime_variant.py.resolve_by_nameandbatch_load_by_idsincluded.What the rows pin:
rbac.enforcement_enabled=falsea user granted nothing edits and deletes but still cannot create.bulk_deleteis a loop, not a transaction: an unknown id behind a known one is refused as not-found after the known one is gone.Deferred, stated in the document: deleting a variant with presets attached — the preset's variant column has a foreign key in the alembic migration but not in the ORM, so the result differs between a migrated database and one built by
schema oneshot.tests/scenario/bai_scenario/components/system.py— the caller-only situation every system-concern table shares — travels in each of the eight sibling PRs byte for byte (#14535, #14536, #14538, #14542, #14543, #14544, #14545). Whichever merges first, the rest rebase clean.Test plan
python3 scripts/knowledge/check.pypassesreport.mdis generated from that run's artifacts withscripts/scenario-report.py --splittest-scenarioandverify-scenario-reportpass on this PR🤖 Generated with Claude Code
https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn