test(BA-7802): add scenario tests for the runtime variant preset adapter - #14522
Closed
jopemachine wants to merge 5 commits into
Closed
Conversation
… use A system entity is created in no scope, so its tables lay no place — only a caller of a given role and the rows the call reads. This is that caller, the enforcement switch the entity gate reads, and the marker an edit uses for a place it must leave as laid. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
Fill adapters/runtime_variant/KNOWLEDGE.md with the scenarios the adapter guarantees and transcribe it into tests/scenario/bai_scenario/manager/runtime_variant/ — 29 rows over five modules. The report is generated from CI run 34558080395. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
Fill adapters/runtime_variant_preset/KNOWLEDGE.md with the scenarios the adapter guarantees and transcribe it into tests/scenario/bai_scenario/manager/runtime_variant_preset/ — 34 rows over five modules. The report is generated from CI run 34558080395. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
jopemachine
force-pushed
the
test/BA-7802-runtime-variant-preset-scenarios
branch
from
September 11, 2026 03:36
3a6f3cd to
aa03a23
Compare
This was referenced Sep 11, 2026
jopemachine
force-pushed
the
test/BA-7843-runtime-variant-scenarios
branch
2 times, most recently
from
September 11, 2026 04:09
ad5f485 to
1284270
Compare
Member
Author
|
Superseded: the stack was dissolved into independent PRs, one issue each — #14535 (BA-7843 runtime variant), #14536 (BA-7844 preset), #14538 (BA-7845 resource slot type), #14542 (BA-7846 retention policy), #14543 (BA-7847 login client type), #14544 (BA-7848 client IP masking), #14545 (BA-7849 secret), #14546 (BA-7850 service catalog). |
jopemachine
deleted the
test/BA-7802-runtime-variant-preset-scenarios
branch
September 11, 2026 04:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked PRs
Part of the system concern scenario stack (BA-7802). Merge in order (bottom-up):
test(BA-7802): shared components the system concern scenarios usetest(BA-7802): runtime varianttest(BA-7802): runtime variant preset ← you are heretest(BA-7802): resource slot typetest(BA-7802): retention policytest(BA-7802): login client typetest(BA-7802): client IP maskingtest(BA-7802): secretPart of BA-7802
Summary
api/adapters/runtime_variant_preset/KNOWLEDGE.mdand transcribe it intotests/scenario/bai_scenario/manager/runtime_variant_preset/— 34 rows over five modules — withseeds/runtime_variant/preset.pyandcomponents/runtime_variant_preset.py. Sits on test(BA-7802): add scenario tests for the runtime variant adapter #14521 because a preset is laid under a variant.What the rows pin:
InvalidAPIParameterswhere the create rows are not rows at all.batch_load_by_idsis a search narrowed to the ids, so an unknown id is an empty slot rather than a refusal.Deferred, stated in the document: a preset for an unknown variant (the ORM/migration foreign-key split above), and changing only the value type — the service re-checks the default only when a default is sent, so this leaves a mismatched default in place.
Test plan
python3 scripts/knowledge/check.pypassesreport.mdis generated from that run's artifacts withscripts/scenario-report.py --splittest-scenarioandverify-scenario-reportpass on this PR🤖 Generated with Claude Code
https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn