test(BA-7802): add scenario tests for the client IP masking adapter - #14526
Closed
jopemachine wants to merge 2 commits into
Closed
test(BA-7802): add scenario tests for the client IP masking adapter#14526jopemachine wants to merge 2 commits into
jopemachine wants to merge 2 commits into
Conversation
Fill adapters/client_ip_masking/KNOWLEDGE.md with the scenarios the adapter guarantees and transcribe it into tests/scenario/bai_scenario/manager/client_ip_masking/ — 23 rows over three modules. A masking policy has no creator, so the seeder learns to write a GlobalEntityUpserter through upsert_global_entity. The report is generated from CI run 34558080395. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn
This was referenced Sep 11, 2026
Member
Author
|
Superseded: the stack was dissolved into independent PRs, one issue each — #14535 (BA-7843 runtime variant), #14536 (BA-7844 preset), #14538 (BA-7845 resource slot type), #14542 (BA-7846 retention policy), #14543 (BA-7847 login client type), #14544 (BA-7848 client IP masking), #14545 (BA-7849 secret), #14546 (BA-7850 service catalog). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked PRs
Part of the system concern scenario stack (BA-7802). Merge in order (bottom-up):
test(BA-7802): shared components the system concern scenarios usetest(BA-7802): runtime varianttest(BA-7802): runtime variant presettest(BA-7802): resource slot typetest(BA-7802): retention policytest(BA-7802): login client typetest(BA-7802): client IP masking ← you are heretest(BA-7802): secretPart of BA-7802
Summary
api/adapters/client_ip_masking/KNOWLEDGE.mdand transcribe it intotests/scenario/bai_scenario/manager/client_ip_masking/— 23 rows over three modules (upserting, searching, retiring) — withseeds/client_ip_masking/policy.pyandcomponents/client_ip_masking.py.Seederlearns to write aGlobalEntityUpserterthroughupsert_global_entity.What the rows pin:
rbac.enforcement_enabled=falseopens purge and not upsert.Test plan
python3 scripts/knowledge/check.pypassesreport.mdis generated from that run's artifacts withscripts/scenario-report.py --splittest-scenarioandverify-scenario-reportpass on this PR🤖 Generated with Claude Code
https://claude.ai/code/session_01Snp9H2jEVbB2s1C6ixUHGn