Skip to content

Levels: Fix tree collision issue by repositioning specific tree instance #2895 - #2958

Merged
manuq merged 1 commit into
endlessm:mainfrom
Brandon-code96:fix/tree-collision-isolated-2895
Sep 24, 2026
Merged

manuq merged 1 commit into
endlessm:mainfrom
Brandon-code96:fix/tree-collision-isolated-2895

Conversation

@Brandon-code96

@Brandon-code96 Brandon-code96 commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the tree collision issue by adjusting the position of a single specific tree instance within the level scene.

The global base tree scene remains completely unmodified, ensuring no unintended side effects on other trees or levels.

Resolves #2895

@Brandon-code96
Brandon-code96 requested a review from a team as a code owner September 22, 2026 20:52
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Test build no longer available.

@KarmDK

KarmDK commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Hi! The PR continues to include old changes.
image

@manuq manuq left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brandon-code96 please check what @KarmDK said. There are a lot of unrelated changes in this pull request.

Besides, from the title and description (thanks for the explanation, though!) I can see what are you attempting to do. Please read the issue again, what needs to be done is much more simple. Just move this tree:

Image

That is, change its position so the player can't get stuck on it. That's it!

@Brandon-code96
Brandon-code96 force-pushed the fix/tree-collision-isolated-2895 branch from 5081ddc to 8a6664f Compare September 23, 2026 18:26

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the pull request title and description, describing the current change (not the previous explorations). See https://github.com/endlessm/threadbare/wiki/Contributing#pull-request-descriptions

Comment thread scenes/quests/lore_quests/quest_000/1_ruined_village/tutorial_ruined_village.tscn Outdated
@Brandon-code96 Brandon-code96 changed the title Levels: Fix tree collision shape locally using editable children #2895 Levels: Fix tree collision issue by repositioning specific tree instance #2895 Sep 24, 2026
@Brandon-code96
Brandon-code96 force-pushed the fix/tree-collision-isolated-2895 branch from 8a6664f to e659da4 Compare September 24, 2026 00:59
@manuq
manuq merged commit a1c2e0c into endlessm:main Sep 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player gets stuck on specific tree near water and unravels in first tutorial scene

3 participants