Repository navigation
Conversation
|
Play this branch at https://play.threadbare.game/branches/KarmDK/2248_tower_physics/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
requested changes
Aug 28, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
This PR carries your changes of your previous task (horizontal door). Please sync your fork with main before continuing, and make this PR show only the changes of the current task.
Collaborator
|
@KarmDK for the record you don't have to close the pull request and open a new one, you can always update it. |
Contributor
Author
|
Oh, I understand. So, should I update this one or wait for a reply to the other one? Sorry. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds collision physics and visual occlusion to the tower. Previously, the tower only existed as a visual sprite, allowing the player to pass through it and guards to detect them through the structure.
The tower scene has been updated with a StaticBody2D containing collision shapes for environmental collisions and visual occlusion, preventing player overlap and ensuring the guard's line of sight is properly blocked. A LightOccluder2D was also added to block the visual projection of the guard's light cone.
Resolves
#2248