Repository navigation
Add debug asserts - #1566
Add debug asserts#1566
Conversation
|
Hi @jwood803 , this approach looks good to me. Thank you for working on it. I'm not certain if @briancylui is still looking at this (he's quite welcome to, just don't think he is). You mention this is a WIP so I imagine there may be more to come, so I will not formally approve just yet. For those methods that take |
|
@Zruty0 @danmosemsft can we revert this change ? some of the debug assumptions are not true. eg in matrix multplivation destionation and src length need not be same |
|
@jwood803 if you want to correct the change, just remove the contracts.Assert statements from the matMul, matMulTrans and matmulP in a PR ? |
Potential fix for #828
@briancylui Is this on the right track to what was needed? Do you think we should do the same to the
AvxIntrinsicsclass, as well?