Skip to content

CpuMath has a bad project reference to ML.Core #1688

Closed
Closed
CpuMath has a bad project reference to ML.Core#1688
Assignees
wschin
Labels
bugSomething isn't working
Milestone
1118

Description

@eerhardt
eerhardt
opened on Nov 20, 2018

See #1659 (comment)

We recently made CpuMath depend on ML.Core, but this is broken.

The Microsoft.ML nuget package depends on the Microsoft.ML.CpuMath NuGet package. So having the CpuMath.dll depend on Microsoft.ML.Core is backwards.

See #542 for the reasoning why this was done that way.

Activity

  1. eerhardt
    assigned
    wschin
    on Nov 20, 2018

  2. jwood803 commented on Nov 21, 2018

    @jwood803
    jwood803
    on Nov 21, 2018
    Contributor

    @eerhardt I was looking at this while messing with an additional fix for #1566. Am I correct in thinking that Microsoft.ML.Core should have a NuGet package reference to Microsoft.Ml.CpuMath? Since it's in the same project does it need to reference the nupkgproj?

  3. shauheen
    added
    bugSomething isn't working
    on Nov 21, 2018
  4. shauheen
    added this to the 1118 milestone on Nov 21, 2018

  5. Zruty0 commented on Nov 21, 2018

    @Zruty0
    Zruty0
    on Nov 21, 2018
    Contributor

    I wonder why don't we simply make it one NuGet?

  6. eerhardt commented on Nov 21, 2018

    @eerhardt
    eerhardt
    on Nov 21, 2018
    MemberAuthor

    #534 Explains why we didn’t make it one NuGet package

  7. wschin
    closed this as completedin #1724on Nov 27, 2018
  8. ghost locked as resolved and limited conversation to collaborators on Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions