Repository navigation
CpuMath Enhancement: Add Debug.Assert to check matching lengths of arguments to SSE/AVX intrinsics #828
Closed as not planned
Description
Activity
- changed the title
[-]Add Debug.Assert to check matching lengths of arguments to SSE/AVX intrinsics[/-][+]CpuMath Enhancement: Add Debug.Assert to check matching lengths of arguments to SSE/AVX intrinsics[/+]on Sep 6, 2018 However, these are internal functions that are only called from functions that guarantee the arguments are checked, so it might not be a blocking issue.
This is not a reason not to do it. Asserts are only called from debug anyway, so there is no question of them having user facing impact. They are for detecting whether we have bugs internally. (If there were any chance of them being called outside they should be checks.)
The intrinsic methods already assert that the requested element count fits within each source and destination span. Requiring the spans themselves to have equal lengths would be unnecessarily restrictive and does not improve correctness.
- locked and limited conversation to collaborators
on Oct 4, 2026
Style changes needed to solve part of #823
Details
src\Microsoft.ML.CpuMath\SseIntrinsics.cs, it may make sense to add someDebug.Assertsto check thesrcanddstLengths match. However, these are internal functions that are only called from functions that guarantee the arguments are checked, so it might not be a blocking issue. It just may be some nice documentation on the expectations of these methods. And in case they get new callsites in the future.