Skip to content

[release/10.0] Source code updates from dotnet/dotnet - #69301

Merged
wtgodbe merged 6 commits into
release/10.0from
darc-release/10.0-0d0303e2-242c-40ac-994d-b17246f1ea00
Sep 15, 2026
Merged

wtgodbe merged 6 commits into
release/10.0from
darc-release/10.0-0d0303e2-242c-40ac-994d-b17246f1ea00

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

New Dependencies

Updated Dependencies

  • From 10.0.13 to 10.0.13
    • dotnet-ef
    • Microsoft.Bcl.AsyncInterfaces
    • Microsoft.Bcl.Cryptography
    • Microsoft.Bcl.TimeProvider
    • Microsoft.EntityFrameworkCore
    • Microsoft.EntityFrameworkCore.Design
    • Microsoft.EntityFrameworkCore.InMemory
    • Microsoft.EntityFrameworkCore.Relational
    • Microsoft.EntityFrameworkCore.Sqlite
    • Microsoft.EntityFrameworkCore.SqlServer
    • Microsoft.EntityFrameworkCore.Tools
    • Microsoft.Extensions.Caching.Abstractions
    • Microsoft.Extensions.Caching.Memory
    • Microsoft.Extensions.Configuration
    • Microsoft.Extensions.Configuration.Abstractions
    • Microsoft.Extensions.Configuration.Binder
    • Microsoft.Extensions.Configuration.CommandLine
    • Microsoft.Extensions.Configuration.EnvironmentVariables
    • Microsoft.Extensions.Configuration.FileExtensions
    • Microsoft.Extensions.Configuration.Ini
    • Microsoft.Extensions.Configuration.Json
    • Microsoft.Extensions.Configuration.UserSecrets
    • Microsoft.Extensions.Configuration.Xml
    • Microsoft.Extensions.DependencyInjection
    • Microsoft.Extensions.DependencyInjection.Abstractions
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.Diagnostics
    • Microsoft.Extensions.Diagnostics.Abstractions
    • Microsoft.Extensions.FileProviders.Abstractions
    • Microsoft.Extensions.FileProviders.Composite
    • Microsoft.Extensions.FileProviders.Physical
    • Microsoft.Extensions.FileSystemGlobbing
    • Microsoft.Extensions.Hosting
    • Microsoft.Extensions.Hosting.Abstractions
    • Microsoft.Extensions.Http
    • Microsoft.Extensions.Logging
    • Microsoft.Extensions.Logging.Abstractions
    • Microsoft.Extensions.Logging.Configuration
    • Microsoft.Extensions.Logging.Console
    • Microsoft.Extensions.Logging.Debug
    • Microsoft.Extensions.Logging.EventLog
    • Microsoft.Extensions.Logging.EventSource
    • Microsoft.Extensions.Logging.TraceSource
    • Microsoft.Extensions.Options
    • Microsoft.Extensions.Options.ConfigurationExtensions
    • Microsoft.Extensions.Options.DataAnnotations
    • Microsoft.Extensions.Primitives
    • Microsoft.NET.Runtime.MonoAOTCompiler.Task
    • Microsoft.NET.Runtime.WebAssembly.Sdk
    • Microsoft.NETCore.App.Ref
    • System.Collections.Immutable
    • System.Composition
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Diagnostics.EventLog
    • System.Diagnostics.PerformanceCounter
    • System.DirectoryServices.Protocols
    • System.Formats.Asn1
    • System.Formats.Cbor
    • System.IO.Hashing
    • System.IO.Pipelines
    • System.Memory.Data
    • System.Net.Http.Json
    • System.Net.Http.WinHttpHandler
    • System.Net.ServerSentEvents
    • System.Numerics.Tensors
    • System.Reflection.Metadata
    • System.Resources.Extensions
    • System.Runtime.Caching
    • System.Security.Cryptography.Pkcs
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.ServiceProcess.ServiceController
    • System.Text.Encodings.Web
    • System.Text.Json
    • System.Threading.AccessControl
    • System.Threading.Channels
    • System.Threading.RateLimiting
  • From 10.0.13-servicing.26461.103 to 10.0.13-servicing.26465.101
    • Microsoft.Extensions.HostFactoryResolver.Sources
    • Microsoft.Internal.Runtime.AspNetCore.Transport
    • Microsoft.NETCore.BrowserDebugHost.Transport
    • Microsoft.NETCore.Platforms
  • From 10.0.0-beta.26461.103 to 10.0.0-beta.26465.101
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Archives
    • Microsoft.DotNet.Build.Tasks.Installers
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.RemoteExecutor
    • Microsoft.DotNet.SharedFramework.Sdk
  • From 3.2.13 to 3.2.13
    • Microsoft.Web.Xdt
  • From 7.0.3-rc.46203 to 7.0.3-rc.46601
    • NuGet.Frameworks
    • NuGet.Packaging
    • NuGet.Versioning

Associated changes in source repos

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/dotnet:939a1706111f6d91a1e95242fec39860e8d9cc60..https://github.com/dotnet/aspnetcore:darc-release/10.0-0d0303e2-242c-40ac-994d-b17246f1ea00

Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.Cryptography, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.NETCore.App.Ref, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 10.0.13 -> 10.0.13)
Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.Platforms (Version 10.0.13-servicing.26461.103 -> 10.0.13-servicing.26464.112)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.26461.103 -> 10.0.0-beta.26464.112)
Microsoft.Web.Xdt (Version 3.2.13 -> 3.2.13)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.0.3-rc.46203 -> 7.0.3-rc.46512)

Added Dependencies:
Microsoft.DotNet.Helix.JobMonitor (Version 10.0.0-beta.26464.112)
[[ commit created by automation ]]
@dotnet-maestro
dotnet-maestro Bot requested a review from halter73 as a code owner September 15, 2026 00:25
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

VMR PRs included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-policy-service dotnet-policy-service Bot added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Sep 15, 2026

@dotnet-policy-service dotnet-policy-service Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@akoeplinger

Copy link
Copy Markdown
Member

@BrennanConroy the test failures look related to the changes, we're also seeing them in the 11.0 PR: #69256

Quick analysis from Copilot:


Yes—there’s a strong, direct connection to the IISMiddleware change. This looks like an outdated assertion in the shared test application, rather than broken WebSocket transport.

What changed

In src/Servers/IIS/IISIntegration/src/IISMiddleware.cs, the PR stops clearing IHttpMaxRequestBodySizeFeature.MaxRequestBodySize by default. Clearing it now requires the Microsoft.AspNetCore.Server.IISIntegration.ClearMaxRequestBodySize AppContext switch.

Previously, the out-of-process tests therefore always saw null, regardless of whether upgrading the connection changed the value.

Why these three tests fail together

All three endpoints call the same Upgrade(context) helper in Startup.WebSockets.cs. Immediately after upgrading, it asserts that the body-size limit is null:

// Upgrade the connection
Stream opaqueTransport = await upgradeFeature.UpgradeAsync();
Assert.Null(context.Features.Get<IHttpMaxRequestBodySizeFeature>().MaxRequestBodySize);

// Get the WebSocket object
var ws = WebSocket.CreateFromStream(opaqueTransport, isServer: true, subProtocol: null, keepAliveInterval: TimeSpan.FromMinutes(2));

Kestrel’s upgrade implementation doesn’t clear that property. Its getter still returns the configured value; upgrading instead makes the feature read-only (HttpProtocol.FeatureCollection.cs, lines 198–220 and 259–290).

The resulting sequence is:

  1. IIS middleware now preserves the configured limit.
  2. The connection upgrades.
  3. The shared helper’s Assert.Null fails before creating the server-side WebSocket or sending any messages.

That explains the same failures under both IIS and IISExpress out-of-process hosting. It also predicts an assertion failure in the server logs, potentially surfaced as a connection-aborted/premature-close error on the client—not necessarily a request-body-too-large error.

An additional useful cross-check: AttemptCompressionWorks uses AcceptWebSocketAsync directly rather than this helper, so this particular assertion would not affect it (Startup.WebSockets.cs, lines 110–130).

Suggested fix

Make the shared helper assert the invariant both servers support—read-only after upgrade—rather than requiring the property to become null:

 Stream opaqueTransport = await upgradeFeature.UpgradeAsync();
-Assert.Null(context.Features.Get<IHttpMaxRequestBodySizeFeature>().MaxRequestBodySize);
+Assert.True(context.Features.Get<IHttpMaxRequestBodySizeFeature>().IsReadOnly);

Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.Cryptography, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.NETCore.App.Ref, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 10.0.13 -> 10.0.13)
Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.Platforms (Version 10.0.13-servicing.26464.112 -> 10.0.13-servicing.26464.118)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.JobMonitor, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.26464.112 -> 10.0.0-beta.26464.118)
Microsoft.Web.Xdt (Version 3.2.13 -> 3.2.13)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.0.3-rc.46512 -> 7.0.3-rc.46518)
[[ commit created by automation ]]
@akoeplinger

Copy link
Copy Markdown
Member

Ah just saw that the test issue was already fixed in #69187 (comment), @rokonec I assume we should cherry-pick that commit here and in the 11.0 PR?

@BrennanConroy why were the backports to 8.0/9.0 closed?

Updated Dependencies:
Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.Cryptography, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.NETCore.App.Ref, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 10.0.13 -> 10.0.13)
Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.Platforms (Version 10.0.13-servicing.26464.118 -> 10.0.13-servicing.26465.101)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.JobMonitor, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.26464.118 -> 10.0.0-beta.26465.101)
Microsoft.Web.Xdt (Version 3.2.13 -> 3.2.13)
NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.0.3-rc.46518 -> 7.0.3-rc.46601)
[[ commit created by automation ]]
@BrennanConroy

Copy link
Copy Markdown
Member

Because I thought the PR I was backporting was the test fix, not the whole change. We should cherry-pick the test fix into 8, 9, 10, and 11.

@wtgodbe

wtgodbe commented Sep 15, 2026

Copy link
Copy Markdown
Member

Because I thought the PR I was backporting was the test fix, not the whole change. We should cherry-pick the test fix into 8, 9, 10, and 11.

Doing that now

- in-process must clear the limit on upgrade because its read loop enforces it
- out-of-process runs on Kestrel, which never enforces it once upgraded
- unblocks the three WebSocketsOutOfProcessTests failures

🧪 - Generated by Copilot

(cherry picked from commit befb2e9)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Port the PackageVersion correction from #66303 so stable servicing packages are restored by their actual version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@wtgodbe
wtgodbe merged commit 6f6182a into release/10.0 Sep 15, 2026
39 checks passed
@wtgodbe
wtgodbe deleted the darc-release/10.0-0d0303e2-242c-40ac-994d-b17246f1ea00 branch September 15, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants