Repository navigation
Conversation
- in-process must clear the limit on upgrade because its read loop enforces it - out-of-process runs on Kestrel, which never enforces it once upgraded - unblocks the three WebSocketsOutOfProcessTests failures 🧪 - Generated by Copilot (cherry picked from commit befb2e9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Backport of befb2e9.
The shared IIS WebSocket test application asserted that
IHttpMaxRequestBodySizeFeature.MaxRequestBodySizewas cleared after upgrading for both hosting models. In-process hosting requires that behavior because its read loop enforces the limit, but out-of-process hosting runs on Kestrel, which does not enforce the limit after upgrade.Scope the assertion to in-process hosting so the following out-of-process tests do not close the WebSocket prematurely:
OnStartedCalledForWebSocketCanSendAndReceieveDataWebReadBeforeUpgradeThe same fix was applied directly to #69256 and #69301.