Repository navigation
Conversation
- in-process must clear the limit on upgrade because its read loop enforces it - out-of-process runs on Kestrel, which never enforces it once upgraded - unblocks the three WebSocketsOutOfProcessTests failures 🧪 - Generated by Copilot (cherry picked from commit befb2e9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
🟢 Approval recommended
The hosting-specific assertion change has no unresolved review issues.
Pull request overview
Scopes the WebSocket request-body assertion to IIS in-process hosting, preventing premature closure in out-of-process tests.
Changes:
- Detects in-process hosting via
IServerVariablesFeature. - Retains the assertion only for in-process requests.
File summaries
| File | Description |
|---|---|
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.WebSockets.cs |
Limits the request-body assertion to in-process hosting. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Backport of befb2e9.
The shared IIS WebSocket test application asserted that
IHttpMaxRequestBodySizeFeature.MaxRequestBodySizewas cleared after upgrading for both hosting models. In-process hosting requires that behavior because its read loop enforces the limit, but out-of-process hosting runs on Kestrel, which does not enforce the limit after upgrade.Scope the assertion to in-process hosting so the following out-of-process tests do not close the WebSocket prematurely:
OnStartedCalledForWebSocketCanSendAndReceieveDataWebReadBeforeUpgradeThe same fix was applied directly to #69256 and #69301.