Repository navigation
fix(protocol): regenerate OpenAPI documents - #1628
Merged
Merged
Conversation
packages/protocol/openapi.json was stale on main: check:generated exited 1. Regenerating adds the description properties now present in the schemas (policies, skills discovery, instructions, deprecated provider policies); the model hidden properties from #1547 are already present on current main. services/www copies regenerated from the updated protocol document (also catching up the give-ups description), so all three documents are identical and check:generated exits 0 in packages/protocol and services/www. packages/client check:generated still fails on clean main with Unportable schema: config.config.get.success — pre-existing, verified with this change stashed, and covered by PR #1604.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1560
What
Regeneration only — no schema or handler code changes:
packages/protocol/openapi.json: regenerated (bun run generateinpackages/protocol)services/www/openapi.json+services/www/public/openapi.json: regenerated from the updated protocol document (bun script/generate-openapi.tsinservices/www)All three documents are now byte-identical.
Current drift (updated evidence)
On current
main(20a17ce) the modelhiddenproperties from PR #1547 are already present in the protocol document; the remaining drift that keptcheck:generatedred is description properties now present in the schemas:policies: "Ordered policies controlling access to providers, tools, and integrations"policiesdescriptionVerification
bun run check:generatedinpackages/protocol→ exit 1, "Generated OpenAPI document is stale."check:generatedexits 0 inpackages/protocoland inservices/www.packages/clientcheck:generatedstill exits 1, but identically on cleanmainwith this change stashed:Unportable schema: config.config.get.successin httpapi-codegen — pre-existing, unrelated to these JSON documents, and covered by PR fix(httpapi-codegen): support imported nonportable success schemas #1604 (issue fix(client): client codegen fails on main — Unportable schema: config.config.get.success #1592).Queue task 8814.