Skip to content

fix(httpapi-codegen): support imported nonportable success schemas - #1604

Merged
dezren39 merged 1 commit into
mainfrom
queue/9307-1592-client-codegen-config-success
Nov 5, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/9307-1592-client-codegen-config-success

Conversation

@dezren39

@dezren39 dezren39 commented Nov 4, 2026 •

Copy link
Copy Markdown

Summary

  • Preserve nonportable success schemas for authoritative imported Effect clients, marking them nonportable so standalone Effect emission remains strict.
  • Add regression coverage for imported Effect clients, Promise output types, and strict transport-input portability.

Closes #1592.

Verification

  • bun test test/generate.test.ts (93 passed)
  • bun run typecheck in packages/httpapi-codegen and packages/client
  • bun run generate and bun run check:generated in packages/client

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a96f474b-7cca-4794-a4d4-1f444f58f973
Commits

Reviewing files that changed from the base of the PR and between 53f06c2 and e9c8179.

Files selected for processing: 2
  • packages/httpapi-codegen/src/index.ts
  • packages/httpapi-codegen/test/generate.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T07:24:29.109203Z e9c8179 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit b6481d9 into main Nov 5, 2026
1 check passed
@dezren39
dezren39 deleted the queue/9307-1592-client-codegen-config-success branch November 5, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(client): client codegen fails on main — Unportable schema: config.config.get.success

1 participant