Repository navigation
CI: test framework, part II - #3890
Merged
Merged
Conversation
apostasie
force-pushed
the
sub-project-testing-2
branch
3 times, most recently
from
February 21, 2025 23:05
7363284 to
2f941a6
Compare
apostasie
marked this pull request as ready for review
February 22, 2025 00:25
apostasie
marked this pull request as draft
February 22, 2025 04:47
apostasie
force-pushed
the
sub-project-testing-2
branch
from
February 22, 2025 20:00
2f941a6 to
472a2b0
Compare
apostasie
changed the title
apostasie
changed the title
Contributor
Author
apostasie
force-pushed
the
sub-project-testing-2
branch
from
February 24, 2025 17:34
472a2b0 to
e4b5b26
Compare
apostasie
changed the title
apostasie
marked this pull request as ready for review
February 24, 2025 17:43
apostasie
force-pushed
the
sub-project-testing-2
branch
from
February 24, 2025 18:37
e4b5b26 to
8474bbd
Compare
apostasie
marked this pull request as draft
February 26, 2025 03:03
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
sub-project-testing-2
branch
from
February 26, 2025 03:31
8474bbd to
4b765cd
Compare
apostasie
marked this pull request as ready for review
February 26, 2025 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #3889 (on top of #3591) - should be merged in order.This specific PR does cleanup and reorganize the
testutil/testpackage.Although this PR looks "large", it is not functionally changing anything (and is only touching tests and testing tools anyhow).
The key take-aways here are:
mod/tigron)expect(expect.Contains, expect.Match, expect.ExitCode)require(require.Arm64, etc)test(test.Case, etc)test.Requirebecomesrequire.All)A
tigronis a tigon in french :) (the offspring of a tiger and a lion)The next PR after that will focus on linting code with more stringent standards.