Skip to content

CI: make the test framework usable standalone in other projects - #3889

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
apostasie:sub-project-testing
Feb 24, 2025
Merged

AkihiroSuda merged 1 commit into
containerd:mainfrom
apostasie:sub-project-testing

Conversation

@apostasie

Copy link
Copy Markdown
Contributor

Note this is on top of #3591, which must be merged first.

This PR makes the testing framework usable in other projects as an independent module.

Directory renaming and re-organization of the subpackage will come next.

cc @AkihiroSuda

@apostasie
apostasie marked this pull request as draft February 15, 2025 22:08
@apostasie apostasie changed the title Make the test framework usable standalone in other projects [WIP] Make the test framework usable standalone in other projects Feb 15, 2025
@apostasie
apostasie force-pushed the sub-project-testing branch 4 times, most recently from bd02fd7 to 1f86e02 Compare February 16, 2025 00:14
@apostasie apostasie changed the title [WIP] Make the test framework usable standalone in other projects Make the test framework usable standalone in other projects Feb 16, 2025
@apostasie
apostasie marked this pull request as ready for review February 16, 2025 00:55
@AkihiroSuda AkihiroSuda added this to the v2.x.x (tentative) milestone Feb 20, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 20, 2025
Comment thread go.mod Resolved
Comment thread go.mod Resolved
Comment thread pkg/testutil/test/Makefile Resolved
Comment thread pkg/testutil/test/README.md Resolved
Comment thread pkg/testutil/test/go.mod Resolved
@apostasie
apostasie force-pushed the sub-project-testing branch 2 times, most recently from e8c8e5f to 7a71f24 Compare February 21, 2025 18:19
@apostasie

Copy link
Copy Markdown
Contributor Author

rootless v2 failure is the timeout linked to github cache outlined in #3850.

Kube failure is the usual Docker Hub 429.

rootless 1.6 fail is bizarre and a bit worrisome:

https://github.com/containerd/nerdctl/actions/runs/13462808635/job/37622050060?pr=3889#step:9:738

--- FAIL: TestRunCap/--cap-drop=all_--cap-add=NET_RAW (0.70s)
FAIL cmd/nerdctl/container.TestRunCap/--cap-drop=all_--cap-add=NET_RAW (0.70s)
=== RUN   TestRunCap
=== PAUSE TestRunCap
=== CONT  TestRunCap
    container_run_security_linux_test.go:67: allCaps=000001ffffffffff
    container_run_security_linux_test.go:48: assertion failed: error is not nil: strconv.ParseUint: parsing "": invalid syntax
--- FAIL: TestRunCap (12.96s)
panic: test executed panic(nil) or runtime.Goexit

goroutine 2480 [running]:
testing.tRunner.func1.2({0x1029160, 0x1b8cb90})
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1[734](https://github.com/containerd/nerdctl/actions/runs/13462808635/job/37622050060?pr=3889#step:9:735) +0x21c
testing.tRunner.func1()
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1737 +0x35e
runtime.Goexit()
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/runtime/panic.go:631 +0x5e
testing.(*common).FailNow(0xc0005e3180)
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1041 +0x4a
gotest.tools/v3/assert.NilError({0x1380b10, 0xc0005e3180}, {0x1375560, 0xc0003eb290}, {0x0, 0x0, 0x0})
	/home/rootless/go/pkg/mod/gotest.tools/v3@v3.5.2/assert/assert.go:177 +0xee
github.com/containerd/nerdctl/v2/cmd/nerdctl/container.getCapEff(0xc00034a000, {0xc000058dc0?, 0x2?, 0x61?})
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/container/container_run_security_linux_test.go:48 +0x52c
github.com/containerd/nerdctl/v2/cmd/nerdctl/container.TestRunCap.func1(0xc00044fc00)
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/container/container_run_security_linux_test.go:114 +0x6a
testing.tRunner(0xc00044fc00, 0xc00049ad20)
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1792 +0xf4
created by testing.(*T).Run in goroutine 1694
	/home/rootless/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.24.0.linux-amd64/src/testing/testing.go:1851 +0x413
FAIL cmd/nerdctl/container.TestRunCap (12.96s)

@apostasie

Copy link
Copy Markdown
Contributor Author

Rebasing to trigger a new CI run.

@apostasie

Copy link
Copy Markdown
Contributor Author

Rebased now that the PTY PR is merged.

@apostasie
apostasie force-pushed the sub-project-testing branch 2 times, most recently from b64b219 to 97af613 Compare February 22, 2025 04:42
@apostasie

Copy link
Copy Markdown
Contributor Author

It is 2025, and CI is still as effed up as in 1995.

This is disheartening.

@apostasie

Copy link
Copy Markdown
Contributor Author

Force-pushing amended commit message to trigger a CI re-run.

@apostasie apostasie changed the title Make the test framework usable standalone in other projects CI: make the test framework usable standalone in other projects Feb 23, 2025
Signed-off-by: apostasie <spam_blackhole@farcloser.world>

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants