Repository navigation
Every Harness module that reaches the opening records it, or reaches it only through a call into one that does (Carbon on #819, record 0215) - #875
Conversation
…ow harness/ is not read as from it, and the opening's mutants each break one rule (#808, record 0215) Carbon's read of PR 819, the findings still open on main. With two steps CALLERS lists as reaching the opening, one that never calls opened, or cannot be read, is now named, where one that did made the check pass. `from . import apply` in a module below harness/ resolves there, not to harness, so it records nothing. Tests add a name bound twice whose last binding is the pulls, PUT and PATCH to the pulls, a POST to one pull request's reviews, opened from harness.read, and the alias and root cases of harness.apply. Three mutants that broke more than their rule now break it alone, and eight more hold the rest. A new Boundaries row in record 0215 names them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ame is held without a parameter shadowing harness (#808, record 0215) Astra: the silent step sorted first, so a check of the first reaching step alone passed; harness/zz_silent.py sorts last, and a mutant that reads only the first is killed by it. Kimi: the case with a parameter named harness does kill "harness.apply imported under another name binds harness", since that parameter is harness's one binding; a case with `harness = ap` at the top kills it too, with no parameter. A case with nothing binding harness is refused either way, by the name bound once, and is kept as the plain refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… function of another that records the opening, as a step calls its job (#808, record 0215) The Claude+security read: CALLERS lists every module that reaches a writer, the job and the step that calls it, so the every-step rule refused the Harness's own split. The Factory Builder's ruling: a call edge, never an import. A module that does not call opened passes when every name it holds for another reaching module, or a function of one, is called as a function that itself records the opening, at least once, and it imports none of the writers' adapter modules, names nothing that rebinds unseen, and makes no relative import below harness/. A step that imports apply and calls the writer itself, one that also calls the adapter, a job's function that records nothing, a recorder named without a call, and a job that leaves the record to its step are refused; the split passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
Code Review
This pull request updates the decision documentation and the tools/check_authority.py script to ensure that every Harness module reaching a pull request opening either records the opening itself or calls another module that does. It introduces the _calls_a_recorder helper function and updates records_the_opening and opening_problems accordingly. A review comment suggests optimizing _calls_a_recorder by caching the functions dictionary to avoid repeatedly walking the AST of imported modules.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68f6c3371e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic



Follow-on to #819 (record 0215), from Carbon's read of #819, which merged before Carbon could read it. Per the Factory Builder, findings on a merged pull request go in a follow-on.
Carbon's 12 findings on #819, sorted against main
fullmatch). This PR adds a case for POST to/repos/%s/pulls/1/reviews...applyat level two. Both only refuse a valid writer; record 0215 accepts that.openedfrom another Harness module, and relative imports belowharness/;asname, and theharnessroot;import harness.apply as …,other.apply.openedandharness.read.opened.The rule for modules that reach the opening (confirmed by the Factory Builder, 2026-11-14)
tools/check_writes.py's CALLERS lists every Harness module that reaches the opening writer. Before, one recording module was enough, so a second one could skipopened.Now each one must record the opening, with one exception. A module that doesn't call
openedpasses only if it reaches the opening solely by calling a function of another reaching module that does, the wayapprove_stepcallsapprove.job. It must also hold to all of these:harness/.Importing a recorder never counts. A module that can't be parsed is silent. A chain longer than one step fails closed.
applyand calls the writer itselfThis stays within 0215's "a step that records nothing does not count". The new Boundaries row says so, and no existing row changes.
Held by
tests/test_tools.py::test_a_role_named_to_open_pull_requests_waits_on_its_writer.tools/check_authority.pyandtools/check_examples.pyare killed; 16 of them are new or retargeted.make checkspasses on this head, with main merged in.Second readers
🤖 Generated with Claude Code