Repository navigation
A check refuses naming a Role to open pull requests while open_pull_request has no writer (#808, record 0215) - #819
Conversation
…equest has no writer (#808) tools/check_authority.py reads the writer from the code's syntax: an adapter that sends a write to a repo's pulls, a step of the Harness that tools/check_writes.py's CALLERS lists as reaching it, and that step's call of harness/apply.py's opened. It names the first part missing; with the Role null, as today, it passes. tools/check_examples.py refuses the counter-example examples/invalid/config.an-opening-role-with-no-writer.json through it. Fifteen mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…equest has its writer (#808) It restates issue 295's limit as before any Role is named to open pull requests, or any contract is in force, amends decisions 0068 and 0047, and names the check and its residual: nothing checks that no contract is in force. A call that builds no request is shown to open nothing; two removal mutants keep their block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ST opens, and harness.apply.opened needs its import The Claude review: a path held in a name bound once, a module's constant, a keyword or an f-string is read, and apply is imported relatively from the Harness too; opened by its own name counts in harness/apply.py alone, tested. Astra and Muse: harness.apply.opened spelt out counts only where import harness.apply binds it; opened imported by its plain name is tested. Muse: a write to the pulls other than POST opens nothing. Record 0215 says so; twelve mutants more, four re-anchored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70cd0b5f0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aa60a03f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|



Fixes #808
A configuration can no longer name a Role to open pull requests until the Effect
open_pull_requesthas its writer. This holds #295's limit by a check rather than by memory. With the Role null, asconfig/defaults.jsonhas it today, the check passes, soconfig/defaults.jsonis untouched and no hand PR is needed.What
The check.
tools/check_authority.pyopening_problemsrefuses a configuration whoseissues.intents["open-pull-request"]is not null unless the code has a writer. The writer is three marks, read from the code's syntax, never by importing it:adapters/function buildsrequest(...)with methodPOSTand path/repos/%s/pullsand nothing after it. Both the method and the path are read as text. A literal counts, and so does:%;harness/module thattools/check_writes.py's CALLERS lists as reaching that function. Because check_writes holds CALLERS true, the check can rely on it.harness/apply.py'sopened, which records the Run that opened the pull request (decision 0097). It can be imported in any of these ways:harness.applyimported whole, as a module or under another name;harness.apply.opened, but only whereimport harness.applybinds it.The refusal names the first mark missing. #342's writer is the change that makes all three true.
Counter-example.
examples/invalid/config.an-opening-role-with-no-writer.jsonis refused bytools/check_examples.pythrough the check, and for that alone.Record 0215, numbered by the Factory Builder, amends decision 0068's row "The Run record" and decision 0047's row "The known limit". It restates #295's limit as "before any Role is named to open pull requests, or any contract is in force". It also names what remains:
openedand reach the opener in separate flows;Held by
tests/test_tools.py::test_a_role_named_to_open_pull_requests_waits_on_its_writer.POST, a write to one pull request, a call that builds no request, and a method or path not written as text are not an opening. Neither is a name bound twice.opened, another module'sopened, orharness.apply.openedwithout the import records nothing.tools/check_authority.pyandtools/check_examples.pyare killed.make checks: red on one check alone. Record 0215 opens a gap until records 0212 to 0214 merge. Then I merge main into this branch and push.Diff: about 36,000 characters.
Second readers
harness.apply.openedcounted with nothing importingharness.apply. Minors: the plainfrom harness.apply import openedform was untested, and any write verb to the pulls counted, though onlyPOSTopensadapters/effects.pywould stay red; andopenedby its own name inharness/apply.pyhad no testThe fixes in 70cd0b5 came after the readers; none of them re-read that head.
🤖 Generated with Claude Code