You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The opening writer's marks refuse a re-bound path, a shadowed opened or apply, a local request, and an unformatted or converted pulls path #868
Gates any pull request that names issues.intents["open-pull-request"] (in config/defaults.json, a hand PR the Maintainer approves, after S6).
PR #819, record 0215, makes tools/check_authority.py refuse an opening Role until open_pull_request has its writer. The writer is three marks read from the code's syntax. Reviewers found six ways a crafted adapter or step can satisfy the marks without a real writer. These are the open side of a check meant to fail closed. They can't be exploited yet, because no opening Role is named. #819 merged as it was so the chain of records 0216 to 0221 keeps its approvals, and this issue's follow-on PR fixes them.
Each of the six is refused, with a case in tests/test_tools.py::test_a_role_named_to_open_pull_requests_waits_on_its_writer and a mutant its test kills.
Record 0215's Boundaries gain a row for the new refusals if tools/check_decisions.py needs one. No new record is needed unless 0215's rule changes.
Declined on #819: nested adapter packages, annotated assignments and relative imports deeper than one level are not read. Each of those only refuses a valid writer, which is the closed side record 0215 accepts.
Activity