Repository navigation
The adapters package imported under another name is an import of the writer's adapter, and record 0215 says which aliased harness.apply records (#876) - #877
Conversation
…writer's adapter, and record 0215 says which aliased harness.apply records (#876, record 0215) The Factory Builder's ruling. `import adapters as api` is ordinary style, and `api.opening.open_pull_request` then calls the writer directly, so a step that imports a package holding a writer's adapter, under any name, does not pass as calling a recorder alone. A new Boundaries row corrects the row #875 added: `import harness.apply as a` with `a.opened(...)` records the opening; only `harness.apply.opened` spelt out with that alias alone records nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request updates the architectural decision record and the implementation of _calls_a_recorder in tools/check_authority.py to refuse imports of a package holding a writer's adapter under any alias (e.g., import adapters as api). The check is implemented by adding m.startswith(full + ".") to the import validation logic. There are no review comments, and I have no additional feedback to provide.
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic



Fixes #876
This follows #875 (record 0215), on the Factory Builder's ruling of 2026-11-14.
import adapters as apiis ordinary style, so good-faith code may write it. Intools/check_authority.py_calls_a_recorder, a step that imports, under any name, a package holding the writer's adapter is now refused as one that imports the writer's adapter. A step that does that cannot callapi.opening.open_pull_requestitself beside the recorder it reaches. A step that importsadapters.github as gh, orfrom adapters import github, is unaffected. A plainimport adapterswas already refused.harness.applyrecords the opening. A new Boundaries row says thatimport harness.apply as a; a.opened(...)records the opening. What records nothing isharness.apply.openedspelt out when only that alias is bound. Every Harness module that reaches the opening records it, or reaches it only through a call into one that does (Carbon on #819, record 0215) #875's row meant this, but its wording said otherwise. No existing row changes.Recorder calls in nested or dead code are still declined, under 0215's good-faith row, as ruled.
Held by
tests/test_tools.py::test_a_role_named_to_open_pull_requests_waits_on_its_writergains theimport adapters as apicase, which is refused.check_authority.pyandcheck_examples.pyare killed.make checkspasses.Second readers
🤖 Generated with Claude Code