[alex09x]

Problem

The direct-query loop in commands/query/lsp_client.rs accepts only a method-less payload with id == 2 and drops everything else (#1520). A prod-code/indexing note, which the gateway sends just before an answer given while the server was still loading or indexing, was discarded. A direct prod-code impls FILE LINE COL then printed a possibly partial list, or "No implementations found", with no hint why.

Change

New busy_note(payload) recognises the prod-code/indexing notification and parses its Busy params. The loop prints it to stderr as "warning: the language server was still indexing (…); the answer below may be incomplete". It does not wait for a complete index, and response matching is unchanged.

Reproduce and verify

New commands::query::lsp_client::tests::an_indexing_note_becomes_a_warning: a note becomes the warning, while an answer and an unrelated notification do not.

Break-check, with the method test inverted so no note is recognised:

an_indexing_note_becomes_a_warning ... FAILED   a note

No live query against a still-indexing server was run.

Measurements

None.

Checks

On a Linux build node, default stable toolchain, one gate on the tree holding #1517, #1519, #1520, #1521 and #1522 (merged one after another):

• cargo test -p prod-code-client --no-fail-fast: first run exit 101, two targets failed, both asserting behaviour these changes replace on purpose:
  • --test cli: lsp_tells_the_editor_when_a_save_did_not_reach_the_node expected the save to reach the server despite the failed sync (Editor bridge forwards didSave after its filesystem sync failed #1517);
  • --test client_ops_2_benchmark: persistent_workers_account_for_churn_and_failed_queries expected 4 verifications in the all-failing case; it now also gets 4 per-copy failures (Divergent benchmark can omit requested worktrees and truncate origin seed names #1522).
    Both were updated, and those two targets were rerun: 115/115 and 2/2.
• cargo clippy -p prod-code-client --all-targets: exit 0. The warnings in touched lsp_bridge files are pre-existing (collapsible_if on the unchanged $/cancelRequest branch, and in reconnect.rs, state.rs, transport.rs).
• cargo fmt --all -- --check: exit 0, after the test edits too.

Closes #1520