Skip to content

Direct CLI LSP queries discard indexing warnings before returning partial results #1520

Closed

Description

@alex09x

Problem

Source-revalidated on main 3f2a835c78e9daba7baefc4c018c6fc9ca3c6e4a.

The response loop accepts only method-less payloads with id=2. A prod-code/indexing notification sent just before a Go/generic managed answer is discarded, while the direct implementations renderer prints the potentially partial list or No implementations found without a readiness note.

Location: crates/prod-code-client/src/commands/query/lsp_client.rs:245-299.

Reproduction boundary

Deliver prod-code/indexing followed by response id=2 to a direct positional impls query. The notification fails the filter and is dropped. This is distinct from MCP secondary-repository warning propagation in #1425.

Expected correction

Retain/render the indexing notification for direct CLI queries and preserve truthful partial/empty-result reporting. Do not wait indefinitely for a complete index or change normal response matching.

Verification limits

Read-only current source inspection; affected files unchanged from the audit checkout. No new tests, build, benchmark, LSP session, server restart or platform run.

Original review findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingclientCLI and MCP client

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions