Editor bridge forwards didSave after its filesystem sync failed #1517

Problem

P2; source-revalidated on main 3f2a835c78e9daba7baefc4c018c6fc9ca3c6e4a.

A failed push_checkout emits a visible warning but falls through to forwarding didSave. The backend can run check-on-save against the old mirrored disk content. keep_checkout_synced retries the upload later but does not replay the save, so stale check results can remain. This is not a claim that the failure is hidden: the warning is an existing partial fix.

Location: crates/prod-code-client/src/lsp_bridge/bridge.rs:259-283.

Reproduction boundary

Keep the LSP connection alive, make only the separate filesystem sync fail during didSave, then allow background sync to recover. Current control flow sends didSave before the successful upload and does not send a replacement after it.

These are source-derived predictions, not a newly executed LSP session or runtime result. Relevant paths are unchanged from the inspected audit checkout; no tests, builds or server restarts ran during this audit.

Expected behavior

Preserve save ordering with the acknowledged filesystem revision: retry/queue the save until its contents arrive, or terminate/surface a failure without causing stale check-on-save results. Preserve protocol responsiveness and avoid indefinitely holding unrelated messages.

Original findings

• prod-code lsp gives editors rust-analyzer, gopls and clangd themselves on the node; Zed extension #337 (comment)