Conversation
Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: Reinis Martinsons <reinis@umaproject.org>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Chris Maree <christopher.maree@gmail.com>
Co-authored-by: Pablo Maldonado <pablo@umaproject.org>
…reporter # Conflicts: # .gitmodules
Co-authored-by: Pablo Maldonado <pablo@umaproject.org>
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final audit review now follows the original branches: #76 at
71d3df10c659542dc5a92028c62f0586efb6b80dand #78 at113e6729f9130ac95795e7c4c7f2a667893aacae. All seven fix PRs (#80–#86) are merged into their original bases. Combining those two final branches exactly reproduces this PR’s repository tree. This draft is retained as an unchanged reference; no merge of this PR is needed for that review.For the reduced final review, see #88: two existing follow-up commits across six files, with the exact same final head as this PR. Its description also links the #84/#80 documentation and interface adjustments already included in the comparison base. This PR remains the complete integration against master.
Integrate #76, #77 and #78 with all six audit fixes (#81–#86) and the callback reserve change (#80) into one branch for final review. The original PR heads are preserved in the merge history. Keep this PR in draft pending final audit review.
Review commit:
7f95d18ae86d4a874953cc951be2606eb1a026da. Tracks FRO-146.Integration decisions:
ResolutionCallbacksFailed; update the callback/recovery documentation and_canonicalRequestIdNatSpec.permit2at slot 0, offset 0. This is the initial proxy layout; the earlier managed-oracle: add UUPS upgradeability to SignedProposer #78 layout used offset 1 and must not be upgraded directly to this build. No migration is included.Validation with Foundry 1.3.6:
forge build --sizes,forge fmt --checkand diff checks pass.