[codex] managed-oo: revert same-block dispute guard - #40
Merged
chrismaree merged 1 commit intoJun 25, 2026
Merged
chrismaree merged 1 commit into
chrismaree merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
managed-oo: disallow same-block disputes).SameBlockDisputeNotAllowederror anddisputePriceForoverride.OptimisticOracleV2.disputePriceForto non-virtual.Why
PR #39 pushed an OOReporter integration concern into
ManagedOptimisticOracleV2. The same-block dispute behavior only becomes a timestamp collision for callback-driven replacement requests under requester-specific assumptions, and OOReporter already owns its replacement timestamp policy viaRequestRerequestTimestampNotAdvanced.Managed OO should not assume what a requester does inside dispute callbacks or which timestamp namespace a replacement request will use.
Validation
forge test --match-path test/ManagedOptimisticOracleV2.t.solcd pm-v2-oo-reporter && forge test --match-path test/OOReporter.t.sol