pm-v2-oo-reporter: standardize lifecycle event fields - #37
Merged
chrismaree merged 1 commit intoJun 23, 2026
Merged
chrismaree merged 1 commit into
chrismaree merged 1 commit into
Conversation
chrismaree
marked this pull request as ready for review
June 23, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
requestIdfollowed byrequestTimestamp.RequestRulesUpdatedandRequestRerequestedfields to match that convention.requestTimestamptoRequestResolvedso resolution logs can be correlated to the active OO request after re-requests.Why
requestIdas the canonical external join key, but lifecycle logs should still be consistent and easy for offchain indexers to consume.RequestRerequestedpreviously placed the actor beforerequestTimestamp, unlikeRequestInitialized.RequestResolveddid not include the active OO timestamp, which made it less self-contained than the other callback-derived lifecycle events.Impact
High risk Sections to review with detail
pm-v2-oo-reporter/src/interfaces/IOOReporter.sol: event signature changes for downstream ABI consumers.pm-v2-oo-reporter/src/OOReporter.sol: emit argument ordering andRequestResolvedtimestamp source.pm-v2-oo-reporter/test/OOReporter.t.sol: test-side mirrored event declarations and emit expectations.Validation
git diff --check.