Skip to content

pm-v2-oo-reporter: standardize lifecycle event fields - #37

Merged
chrismaree merged 1 commit into
unaudited-pm-v2-oo-reporterfrom
chrismaree/oo-reporter-event-standardization
Jun 23, 2026
Merged

chrismaree merged 1 commit into
unaudited-pm-v2-oo-reporterfrom
chrismaree/oo-reporter-event-standardization

Conversation

@chrismaree

Copy link
Copy Markdown
Member

What Changed

  • Standardized request lifecycle event ordering so events that identify a Managed OO request lead with requestId followed by requestTimestamp.
  • Reordered RequestRulesUpdated and RequestRerequested fields to match that convention.
  • Added requestTimestamp to RequestResolved so resolution logs can be correlated to the active OO request after re-requests.
  • Updated reporter tests and README event guidance to match the ABI change.

Why

  • The reporter already uses requestId as the canonical external join key, but lifecycle logs should still be consistent and easy for offchain indexers to consume.
  • RequestRerequested previously placed the actor before requestTimestamp, unlike RequestInitialized.
  • RequestResolved did not include the active OO timestamp, which made it less self-contained than the other callback-derived lifecycle events.

Impact

  • This is an ABI/event-signature change for the unaudited PM v2 reporter branch.
  • Consumers decoding these events need to update their event signatures and positional field assumptions.
  • Contract state and request lifecycle behavior are unchanged.

High risk Sections to review with detail

  • pm-v2-oo-reporter/src/interfaces/IOOReporter.sol: event signature changes for downstream ABI consumers.
  • pm-v2-oo-reporter/src/OOReporter.sol: emit argument ordering and RequestResolved timestamp source.
  • pm-v2-oo-reporter/test/OOReporter.t.sol: test-side mirrored event declarations and emit expectations.

Validation

  • Ran git diff --check.
  • Did not run builds or tests per instruction.

@chrismaree
chrismaree marked this pull request as ready for review June 23, 2026 09:52
@chrismaree
chrismaree merged commit 477088c into unaudited-pm-v2-oo-reporter Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant