Skip to content

Remove EnumMap and EnumSet usages - #4258

Merged
WalshyDev merged 1 commit into
Slimefun:walshy/mc-1.21from
md5sha256:fix/remove-enummap
Nov 9, 2024
Merged

WalshyDev merged 1 commit into
Slimefun:walshy/mc-1.21from
md5sha256:fix/remove-enummap

Conversation

@md5sha256

Copy link
Copy Markdown
Contributor

Description

Removes usages of EnumMap and EnumSet on types which implement Keyed

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@md5sha256
md5sha256 requested a review from a team as a code owner November 9, 2024 21:36
@github-actions github-actions Bot added the ✨ Fix This Pull Request fixes an issue. label Nov 9, 2024
@github-actions

github-actions Bot commented Nov 9, 2024

Copy link
Copy Markdown
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions

github-actions Bot commented Nov 9, 2024

Copy link
Copy Markdown
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: fdfa003

https://preview-builds.walshy.dev/download/Slimefun/4258/fdfa0034

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev
WalshyDev merged commit 47092df into Slimefun:walshy/mc-1.21 Nov 9, 2024
ybw0014 added a commit to ybw0014/Slimefun4 that referenced this pull request Nov 12, 2024
@ybw0014 ybw0014 mentioned this pull request Nov 12, 2024
2 of 7 tasks
orcachillin pushed a commit to CraftYourTown/Slimefun4 that referenced this pull request Nov 23, 2024
orcachillin pushed a commit to CraftYourTown/Slimefun4 that referenced this pull request Nov 23, 2024
WalshyDev added a commit that referenced this pull request Mar 9, 2025
**Note: This is experimental and will break all addons not yet supporting 1.21! Use at your own risk**

* Update to 1.21

* Add a temporary InventoryViewWrapper in tests. Refactor TestBackpackListener to use the wrapper on Player#getOpenInventory

* Wrap the inventory view after the backpack has been opened

* Updates usages of CustomItemStack (#4253)

Co-authored-by: Daniel Walsh <walshydev@gmail.com>

* Remove EnumMap and EnumSet usages (#4258)

---------

Co-authored-by: Andrew Wong <42793301+md5sha256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Fix This Pull Request fixes an issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants