Update to 1.21 by WalshyDev · Pull Request #4248 · Slimefun/Slimefun4

WalshyDev · 2024-10-01T00:23:07Z

Description

Updates to 1.21 - big shout out to MockBukkit team and @Intybyte for the work on tests

Proposed changes

Updated Slimefun code to support 1.21

Related Issues (if applicable)

N/A

Checklist

I have fully tested the proposed changes and promise that they will not break everything into chaos.
I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
I followed the existing code standards and didn't mess up the formatting.
I did my best to add documentation to any public classes or methods I added.
I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
I added sufficient Unit Tests to cover my code.

github-actions · 2024-10-01T00:23:22Z

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

github-actions · 2024-10-01T00:26:08Z

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: e7d9232

https://preview-builds.walshy.dev/download/Slimefun/4248/e7d9232e

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

WalshyDev · 2024-10-01T00:46:13Z

This still needs major testing

JustAHuman-xD · 2024-10-01T03:23:20Z

        ItemStack item = new CustomItemStack(Material.BEACON, "&cItem Test");
        String id = "IS_ITEM_TEST";
-        SlimefunItem sfItem = TestUtilities.mockSlimefunItem(plugin, id, item);
+        SlimefunItem sfItem = TestUtilities.mockSlimefunItem(plugin, id, new CustomItemStack(Material.BEACON, "&cItem Test"));


What's the point of this?

I think its testing that SlimefunItem#register should change the underlying ItemStack in some way, thus sfItem#isItem should return false even if the twoItemStacks were the same when we started.

Boomer-1 · 2024-10-01T04:10:44Z

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

…istener to use the wrapper on Player#getOpenInventory

sonarqubecloud · 2024-10-01T07:57:04Z

Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Boomer-1 · 2024-10-22T15:30:23Z

testing produced multiple errors immediately which stopped any further testing. I've linked them from the contributors channel on discord. https://discord.com/channels/565557184348422174/565570276038017044/1290525215461216266

Is there 1.21 build available? where? ty mate

no. this is the work being done to get 1.21 up and running.

Co-authored-by: Daniel Walsh <walshydev@gmail.com>

sonarqubecloud · 2024-11-09T21:46:55Z

Quality Gate passed

Issues
256 New issues
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

Boomer-1 · 2024-11-21T04:16:51Z

You're leaving an entire bubble out in the rain, you can keep talking about it, but slimefun will soon die for all the servers that once offered it!

please leave unproductive comments like these out of the PR discussion. since you clearly didn't look at what's going on and seen the progress, you aren't helping anyone.

sruly09 · 2024-12-15T03:02:17Z

yay the checklist is shrinking

logicaleman314 · 2025-01-03T01:11:30Z

Wondering what still needs to be done, Both this and the itemstack rewrite have been waiting to merge for almost a month now.
Is there another issue that is being worked on?

Update Addon to Support this pull request : Slimefun/Slimefun4#4248 We will need to change the pom.xml at the end, when there will be an update for 1.21

Update Addon to Support this pull request : Slimefun/Slimefun4#4248 We will need to change the build.gradle.kts at the end, when there will be an update for 1.21

Outfit8TSB · 2025-02-09T09:54:56Z

i made a conflict resolution Branch.
Check #4292.

DejVIIK-Original · 2025-03-08T06:14:30Z

Hello
Approximately when will it be out?
Release date to 1.21.x

Rafasxa · 2025-03-09T00:49:16Z

Hello Approximately when will it be out? Release date to 1.21.x

It will probably take a long time; it seems like they have abandoned the Slimefun project.

sonarqubecloud · 2025-03-09T12:33:47Z

Quality Gate passed

Issues
335 New issues
0 Accepted issues

Measures
0 Security Hotspots
46.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

DejVIIK-Original · 2025-03-09T17:47:51Z

Thanks for Experimental version for Minecraft 1.21

LordDarce · 2025-03-22T15:32:21Z

Shame this is abandonware now, used to be a solid plugin
All the devs are interested in doing is whining at their fanbase in Discord

ybw0014 · 2025-03-22T15:52:02Z

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

@LordDarce Please don't spread misinformation. Slimefun is an open-source project maintained by community devs in their free time. Plus, this PR was merged 2 weeks ago, calling it "abandoned" makes no sense at all.
For the second point, if you have proof of devs "whining" at the fanbase, share it. Otherwise, your statement is baseless and misleading.

LordDarce · 2025-03-22T18:17:59Z

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

@LordDarce Please don't spread misinformation. Slimefun is an open-source project maintained by community devs in their free time. Plus, this PR was merged 2 weeks ago, calling it "abandoned" makes no sense at all. For the second point, if you have proof of devs "whining" at the fanbase, share it. Otherwise, your statement is baseless and misleading.

I'm not documenting the Devs abysmal behavior for you, chief. You can do your own research if you're so upset

Boomer-1 · 2025-03-22T18:52:13Z

stop wasting everyone's time with spreading lies. and stop commenting on here.

TheBusyBiscuit · 2025-03-22T19:10:01Z

I've locked conversation on this pull requests as I have received a complaint report about the conversation here.
We appreciate comments on pull requests but they should be related to the proposed changes, not to just rant about things on here ( We have discord for that ;D ).

Shame this is abandonware now, used to be a solid plugin All the devs are interested in doing is whining at their fanbase in Discord

@LordDarce I understand the concern, feel free to voice it on discord but please don't post spam on our pull requests.
These threads are intended for technical discussions and code reviews. I have no idea what you are talking about in regards to whining devs but also note that this pull request was already merged two weeks ago... into an experimental branch which is available through our builds site.

WalshyDev requested review from a team as code owners October 1, 2024 00:23

WalshyDev force-pushed the walshy/mc-1.21 branch 2 times, most recently from a5de53e to 9f175bf Compare October 1, 2024 00:34

WalshyDev mentioned this pull request Oct 1, 2024

Add multiversion support to ExplosiveTool#createNewBlockExplodeEvent #4245

Closed

2 of 7 tasks

WalshyDev commented Oct 1, 2024

View reviewed changes

Comment thread src/test/resources/biomes/1.21.x.json Resolved

WalshyDev added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🤝 Compatibility This Pull Request introduces a compatibility feature. 🎮 Game Update This pull request adds compatibility with a new version of Minecraft. labels Oct 1, 2024

WalshyDev assigned Sefiraat, svr333, Alessio-Colombo, md5sha256 and Boomer-1 Oct 1, 2024

ybw0014 suggested changes Oct 1, 2024

View reviewed changes

Comment thread pom.xml Resolved

WalshyDev force-pushed the walshy/mc-1.21 branch 4 times, most recently from 41f9139 to afaf3aa Compare October 1, 2024 01:03

Update to 1.21

c84e876

WalshyDev force-pushed the walshy/mc-1.21 branch from afaf3aa to c84e876 Compare October 1, 2024 01:17

JustAHuman-xD reviewed Oct 1, 2024

View reviewed changes

md5sha256 added 2 commits October 1, 2024 15:02

Add a temporary InventoryViewWrapper in tests. Refactor TestBackpackL…

b508e45

…istener to use the wrapper on Player#getOpenInventory

Wrap the inventory view after the backpack has been opened

00da02c

Outfit8TSB mentioned this pull request Nov 9, 2024

1.21 support #4254

Closed

5 tasks done

md5sha256 and others added 2 commits November 9, 2024 19:24

Updates usages of CustomItemStack (#4253)

6f02cae

Co-authored-by: Daniel Walsh <walshydev@gmail.com>

Remove EnumMap and EnumSet usages (#4258)

47092df

This comment was marked as off-topic.

Sign in to view

TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jan 11, 2025

Tiakin added a commit to Tiakin/DyedBackpacks that referenced this pull request Feb 4, 2025

Update to 1.21

d1acc90

Update Addon to Support this pull request : Slimefun/Slimefun4#4248 We will need to change the pom.xml at the end, when there will be an update for 1.21

Tiakin added a commit to Tiakin/MobCapturer that referenced this pull request Feb 4, 2025

Update to 1.21

d68216e

Update Addon to Support this pull request : Slimefun/Slimefun4#4248 We will need to change the build.gradle.kts at the end, when there will be an update for 1.21

This was referenced Feb 14, 2025

Merge 4248 GAME-CLI-SRV-DEV/Slimefun4-GCSD#1

Merged

merge 4248 4251 4278 4292 GAME-CLI-SRV-DEV/Slimefun4-GCSD#2

Open

Merge branch 'master' into walshy/mc-1.21

ccaa265

WalshyDev changed the base branch from master to experimental March 9, 2025 12:29

WalshyDev merged commit 3544459 into experimental Mar 9, 2025

WalshyDev deleted the walshy/mc-1.21 branch March 9, 2025 12:46

Slimefun locked as too heated and limited conversation to collaborators Mar 22, 2025

Conversation

WalshyDev commented Oct 1, 2024

Description

Proposed changes

Related Issues (if applicable)

Checklist

Uh oh!

github-actions Bot commented Oct 1, 2024

Uh oh!

github-actions Bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Slimefun preview build

Uh oh!

Uh oh!

WalshyDev commented Oct 1, 2024

Uh oh!

Uh oh!

JustAHuman-xD Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

md5sha256 Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

Boomer-1 commented Oct 1, 2024

Uh oh!

sonarqubecloud Bot commented Oct 1, 2024

Quality Gate passed

Uh oh!

Boomer-1 commented Oct 22, 2024

Uh oh!

sonarqubecloud Bot commented Nov 9, 2024

Quality Gate passed

Uh oh!

This comment was marked as off-topic.

Boomer-1 commented Nov 21, 2024

Uh oh!

sruly09 commented Dec 15, 2024

Uh oh!

logicaleman314 commented Jan 3, 2025

Uh oh!

Outfit8TSB commented Feb 9, 2025

Uh oh!

DejVIIK-Original commented Mar 8, 2025

Uh oh!

Rafasxa commented Mar 9, 2025

Uh oh!

sonarqubecloud Bot commented Mar 9, 2025

Quality Gate passed

Uh oh!

DejVIIK-Original commented Mar 9, 2025

Uh oh!

LordDarce commented Mar 22, 2025

Uh oh!

ybw0014 commented Mar 22, 2025

Uh oh!

LordDarce commented Mar 22, 2025

Uh oh!

Boomer-1 commented Mar 22, 2025

Uh oh!

TheBusyBiscuit commented Mar 22, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

github-actions Bot commented Oct 1, 2024 •

edited

Loading