Skip to content

Updates usages of CustomItemStack - #4253

Merged
WalshyDev merged 4 commits into
Slimefun:walshy/mc-1.21from
md5sha256:fix/cis
Nov 9, 2024
Merged

WalshyDev merged 4 commits into
Slimefun:walshy/mc-1.21from
md5sha256:fix/cis

Conversation

@md5sha256

@md5sha256 md5sha256 commented Oct 25, 2024 •

Copy link
Copy Markdown
Contributor

Description

Updates to match dough's refactored CustomItemStack (which no longer extends ItemStack)
Updates the mockbukkit dependency to latest from maven central (not jitpack)

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@md5sha256
md5sha256 requested review from a team as code owners October 25, 2024 06:42
@github-actions github-actions Bot added the ✨ Fix This Pull Request fixes an issue. label Oct 25, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions

github-actions Bot commented Oct 25, 2024 •

Copy link
Copy Markdown
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 00d0a28

https://preview-builds.walshy.dev/download/Slimefun/4253/00d0a289

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

This was referenced Nov 7, 2024
Comment thread pom.xml Resolved
@WalshyDev
WalshyDev merged commit 6f02cae into Slimefun:walshy/mc-1.21 Nov 9, 2024
WalshyDev added a commit that referenced this pull request Mar 9, 2025
**Note: This is experimental and will break all addons not yet supporting 1.21! Use at your own risk**

* Update to 1.21

* Add a temporary InventoryViewWrapper in tests. Refactor TestBackpackListener to use the wrapper on Player#getOpenInventory

* Wrap the inventory view after the backpack has been opened

* Updates usages of CustomItemStack (#4253)

Co-authored-by: Daniel Walsh <walshydev@gmail.com>

* Remove EnumMap and EnumSet usages (#4258)

---------

Co-authored-by: Andrew Wong <42793301+md5sha256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Fix This Pull Request fixes an issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants