Repository navigation
Conversation
MuJoCo Warp now depends on mujoco-core, which provides the mujoco module. Explicitly installing mujoco as well lets the two distributions overwrite each other's package files and breaks test collection. Let upstream mujoco_warp choose its MuJoCo dependency in all three CI jobs. Report the mujoco-core version and resolved upstream commit so integration failures can be tied to the exact installed dependencies. Signed-off-by: Eric Shi <ershi@nvidia.com>
[Low impact] The PR appears safe to merge. SummaryRemoves the explicit
No actionable issues found. GPU suites were not run during this review. Reviews (1) · Last reviewed commit: "Fix MuJoCo Warp CI dependency installati..." · Reviewed by Greptile |
|
No actionable comments were generated in the recent review. Summary
Change: Bug fix Merge Risk:
|
What problem are you trying to solve?
The MuJoCo Warp integration job fails during test collection with
AttributeError: module 'mujoco' has no attribute 'mjtTendon'. Upstream mujoco_warp#1927 switched tomujoco-core>=4.0.0, which provides the Python module namedmujoco. Warp CI also explicitly installs the oldmujocodistribution; the two wheels overwrite files in the same package.What does this change?
Remove the explicit
mujocorequirement from the GitHub job and both GitLab jobs, letting upstream mujoco_warp select its MuJoCo dependency. Keep testing upstreammainand preserve the existing test commands, CUDA artifacts, runners, scheduling, and failure policies.Report
mujoco-coremetadata in GitHub, preserving its resolved-commit link. Addmujoco-coreversion and exact mujoco_warp SHA reporting to both GitLab jobs usingdirect_url.jsonanduv run --no-sync python.Existing pull requests
Validation
mainto60dbbdf5fb387181ade656bb9d2c13162c3bec51, the same SHA as the failing run. It installedmujoco-core==4.0.2.dev1019107346without the oldmujocodistribution;import mujoco; import mujoco_warpandmujoco.mjtTendon.mjTENDON_FIXEDsucceeded. Printedmujoco.__version__(4.0.2) and its virtual-environment module path. Confirmed the old GitHub metadata lookup fails in this corrected environment.pytestadded) also passes both imports and the extracted reporting block. The oldmujoco, JAX, and xdist distributions are absent.f41911963b7305eb28a7602cc98226c89a9d08a7,mujoco-core==4.0.2.dev1019107346, and upstream mujoco_warp SHA60dbbdf5fb387181ade656bb9d2c13162c3bec51. The GitLab jobs have not been run; their installation and reporting changes were checked locally.pytest pytest-xdist "jax[cuda13]". Both YAML files parse, all three extracted reporting blocks execute successfully against the VCS-installed package, and GitHub's summary retains the resolved-commit link. Checks confirm all other job settings are unchanged.uv pip check,uvx pre-commit run --files .github/workflows/ci.yml .gitlab-ci.yml, andgit diff --checkpass.Checklist
mainand contains one commit, unless a maintainer agreed to keep the change as multiple commits.+prefix only for changes that do not require a GitHub issue. No fragment is needed for this internal CI maintenance change.