Repository navigation
ci(timing): run the unit legs at -n logical and read latest's JUnit timings (#2571) - #2572
Merged
Merged
Conversation
…imings (#2571) - unit-tests.yml `Run unit tests`: `-n logical`, not `auto`, which counts physical cores once psutil is installed (the `test` extra, CPython), half the runner's CPUs. PyPy has no psutil; there the two agree. `test-ktlo` shares the step by alias. - The `test` matrix comment drops its stale figures and says why the coverage leg is slower: the `LATEST` tier too, under coverage. - util/ci_timing.py: JUNIT_LEGS adds `latest`, read from the tier file with COVERAGE_JOB, so the report names the coverage leg's modules. - test-coverage.rst names the new flag; process.rst's monthly-refresh bullet no longer lists the dropped headroom figure. - Tests: a per-leg `-n logical` pin, a JUNIT_LEGS-has-latest check, and the Windows leg's flags pin re-pinned to each side's `-n` value.
JarryShaw
added
ci
Owner
Author
|
Cross-review (Sonnet) at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 93.94% (unit tier, Python 3.15,
Per-file detail: the |
- test_windows_test_leg_2060.py: the flags docstrings state what is true now, all but `-n`, which only `test`'s step sets to `logical`. - unit-tests.yml: W3 is util/ci_timing.py's, not ci-timing.yml's; the `-n logical` comment is two lines. - test-coverage.rst: `-n logical` is the `test` job's, the unit tier's. - util/ci_timing.py: LATEST_VERSION, so it is not mistaken for the `LATEST` tier; JUNIT_LEGS drops a duplicate leg, which the test pins.
Owner
Author
|
Pushed
The verdict stands. Measured on this PR's CI at |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 1, 2026
- Added: one's-complement checksum verification and computation (#2543), and the IPX and SCTP registration wrappers (#2521). - Folded into unreleased entries: LinuxSLL/FRAD/Netlink registries (#2527), the IGMP class names (#2542), TLS record chaining and the SSLv2 trial's warnings (#2537), DTLS reassembly via Extractor and toolkit (#2528), and IP_Pseudo's walk at any depth (#2543). ICMP drops its stale checksum line. - Breaking: make() checksums, DRARP's module (#2540), IPv6 overlapping fragments (#2569), TCP_GAP_LIMIT replacing TCP.__window__ (#2579), and Extractor/extract's positional dtls (#2528). - Changed: member order (#2490), conventions (#2542, #2521, #2570), CI -n logical (#2572). Fixed: AppType.get (#2568), trial warnings (#2519, #2577). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Closes #2571 (hard finding H1 of ci-timing run 41303273918; H2 is that week's window spanning #2258's split).
Run unit testsuses-n logicalinstead of-n auto. With psutil in thetestextra,autocounts physical cores, so the 4-CPU runner ran 2 workers. The CPython legs, KTLO included, now run 4. PyPy, which has no psutil, is unchanged.util/ci_timing.py:JUNIT_LEGSadds the latest version, derived frompython-versions.toml, so the report names the coverage leg's slowest modules.testjob's matrix comment drops its measured figures and says why the coverage leg is slower. test-coverage.rst and process.rst follow.-n logicalon every unit leg and the latest version inJUNIT_LEGS. Both fail onmain.Python 3.15run gives the before and after. The weekly report after merge re-baselines.