Repository navigation
fix(reassembly)!: move TCP's gap cap into config as PCAPKIT_TCP_GAP_LIMIT (#2546) - #2579
Merged
Merged
Conversation
…IMIT (#2546) - Add config.TCP_GAP_LIMIT, read from PCAPKIT_TCP_GAP_LIMIT, default 16 MiB; -1 lifts it, so a segment always merges, bounded only by the sequence space. - TCP.reassembly reads it at call time; TCP.__window__ is removed with no alias (versionremoved:: 1.6.0), and its split description moves to the reassembly docstring. - Document the variable on the config page, and record on reassembly-integration.rst that the cap is a safety limit, not a reassembly rule. - Tests: a gap up to a patched limit merges, past it splits (with and without a SYN), and -1 merges a gap past the default; drop the stale 1 << 24 entry from the RFC-constants sweep.
JarryShaw
added
fix
Owner
Author
|
Cross-review (Sonnet) at
|
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 1, 2026
- Added: one's-complement checksum verification and computation (#2543), and the IPX and SCTP registration wrappers (#2521). - Folded into unreleased entries: LinuxSLL/FRAD/Netlink registries (#2527), the IGMP class names (#2542), TLS record chaining and the SSLv2 trial's warnings (#2537), DTLS reassembly via Extractor and toolkit (#2528), and IP_Pseudo's walk at any depth (#2543). ICMP drops its stale checksum line. - Breaking: make() checksums, DRARP's module (#2540), IPv6 overlapping fragments (#2569), TCP_GAP_LIMIT replacing TCP.__window__ (#2579), and Extractor/extract's positional dtls (#2528). - Changed: member order (#2490), conventions (#2542, #2521, #2570), CI -n logical (#2572). Fixed: AppType.get (#2568), trial warnings (#2519, #2577). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Closes #2546, per the owner's option 2: TCP's gap cap is a safety limit, not a reassembly rule.
config.TCP_GAP_LIMIT(PCAPKIT_TCP_GAP_LIMIT) follows the other limits:read_limitwith minimum 0, a 16 MiB default as before, and-1meaning no limit. Setting-1or anything above the default warns withConfigWarning(feat(utilities): one config module for the tunable limits (PCAPKIT_* environment variables), and one home per duplicated protocol constant #1726).TCP.reassemblyreads it at call time. With-1a segment always merges, bounded only by the sequence space.TCP.__window__, shipped in 1.5.x, is removed withversionremoved:: 1.6.0and no alias, since a tunable has one home (refactor(corekit)!: move the byte-order field helpers into corekit (#1711) #1715, feat(utilities): one config module for the tunable limits (PCAPKIT_* environment variables), and one home per duplicated protocol constant #1726).