Repository navigation
[access] test(gdpr): cover GdprEntityMapper lookups and OrganisationScopeTable - #7588
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, but the failures do not come from this PR. The job runs the full PHPUnit suite and ends with 11 errors and 11 failures. All of them are in tests this PR does not touch:
The same 22 tests fail on This PR only adds a test file, so there is nothing to fix here and no fix exists yet to port in. I have not re-run the check, because Generated by Claude Code |
|
Frontend Check (test:l10n) is red, but the cause is on The rest of the
A test-only PR can't fix any of these. Each needs its own fix on Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49045/49055 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:40 UTC
Download the full PDF report from the workflow artifacts.
What
New behaviour test (no production code touched) for two scope files below 85%:
GdprEntityMapper—find()binds the id as an integer and throws on a miss;findEntitiesPublic()hydrates every rowMagicMapper\OrganisationScopeTable— named exactly when it carries a register or a schemaMeasured (subset run, lower bound of full suite)
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/t01-sub.xml tests/Unit/Db/GdprEntityMapperAndScopeTableBehaviourTest.php+clover_files.pyFinding:
lib/Db/AuthorizationRulesTrait.php:50-52(thecatcharoundjson_decode) is unreachable —json_decodewithoutJSON_THROW_ON_ERRORnever throws — so that file stays at 8/10.phpcs clean.
weak.phpreports none of the new tests.Mutation samples (each reverted, never committed)
Tests written with Claude Code.
Generated by Claude Code