Repository navigation
[access] test(retention): cover token refresh, tenant deprovisioning and retention sweep jobs - #7586
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…ule-run retention jobs Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is failing, but not because of this PR. The job runs the full PHPUnit suite. It ends with 11 errors and 11 failures, all in tests this PR does not touch:
None of the new The same 22 tests also fail on This PR only adds test files, so there is nothing to fix here. No fix exists yet that could be ported in. I have not re-run the check, because Generated by Claude Code |
|
Frontend Check (format) is red, but not because of this PR. Prettier flags only existing The rest of the
None of these can be fixed from a test-only PR. They need their own fixes on Generated by Claude Code |
|
Frontend Tests (unit) is red, but not because of this PR. All 4,965 jest tests passed. The failure is one suite that Jest cannot load: Frontend Check (test:l10n) is also red. That one is already explained in my previous comment. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49065/49075 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 18:20 UTC
Download the full PDF report from the workflow artifacts.
What
New behaviour tests (no production code touched) for 8 retention, deprovisioning and token-refresh background classes:
OAuth2TokenRefreshJob(+OAuth2TokenRefreshServices) — daily interval; only active token sets with a uuid whose provider is a token-set provider are swept, with scope defaulting topersonal; relink is not counted as failure, other errors are; a failing listing stops the runTenantDeprovisionJob— every deprovisioning tenant archived, one failure does not stop the rest, a failing query archives nothingArchivalRetentionTaskfailure and skip paths — register/schema/table-check/scan failures delete nothing, non-annotated schemas skipped, missing table not scanned, expired row without uuid counted but untouched, unreadable object kept as unresolved, refused/failing delete not counted, held row without archivist group notifies nobody, failing notifier does not stop the sweepProcessingLogRetentionJob— purge that cannot be recorded is logged with its figures; prune of nothing records nothing (frozen clock)RuleRunRetentionJob— nothing removed logs nothing; removal count loggedRelatedRetentionLookup,RelatedRetentionRules— bundles hand back each collaborator under its nameMeasured (subset run, lower bound of full suite)
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/t01-sub.xml <new files> tests/Unit/BackgroundJob/{ArchivalRetentionTask,ProcessingLogRetentionJob,RuleRunRetentionJob}Test.php+clover_files.pyThe one remaining ArchivalRetentionTask statement (line 287, non-array schema configuration) looks unreachable:
Schema::getConfiguration()returns an array or null.42 tests green. phpcs clean.
weak.phpreports none of the new tests.Mutation samples (each reverted, never committed)
Tests written with Claude Code.
Generated by Claude Code