Repository navigation
[access] test(organisation): cover OrganisationMapper behaviour - #7549
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
|
The Newman API Test Suite check (api-test-coverage) is red, but the cause is not in this PR. The job runs the full PHPUnit suite. It ends with 11 errors and 11 failures, all in test files this PR does not touch:
The same 22 tests fail on Generated by Claude Code |
|
Two l10n checks are red on this PR, but the cause is on
Both fixes belong in the repo's own l10n commits, made through Generated by Claude Code |
|
Frontend Check (format) is red, but not because of this PR. Prettier flags 114 existing files, and every one is under Generated by Claude Code |
|
Vue Quality (eslint) fails here with the same errors already explained on #7526. They are unused imports, triple-dot translated strings and import ordering, all in existing files under The other quality checks this PR shares with #7526 come from Generated by Claude Code |
|
PHP Quality (phpmd) fails, but not because of this PR. Every violation it reports (615 entries) points at existing production code under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 16:34 UTC
Download the full PDF report from the workflow artifacts.
What
New behaviour test
tests/Unit/Db/OrganisationMapperBehaviourTest.php(no production code touched) forlib/Db/OrganisationMapper.php, the tenancy root mapper:save(): generated uuid, malformed uuid refused, uuid held by another organisation refused (exclusion of own id), slug taken before insert, insert race on the slug surfaces asOrganisationSlugConflictExceptionwith the cause, other insert failures logged and rethrown, update pathenabled, default organisation key vs JSON blob vs absentfindByUuidFollowingMergeExisting golden tests for this mapper declare a narrow
@covers; underbeStrictAboutCoverageMetadatathey are risky and their coverage is discarded, which is why CI showed 0/430. The new test carries no@covers.Measured (subset run, lower bound of full suite)
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/t01-sub.xml tests/Unit/Db/OrganisationMapperBehaviourTest.php+clover_files.py51 tests, 121 assertions, green. phpcs clean.
weak.phpreports none of the new tests.Mutation samples (each reverted, never committed)
Tests written with Claude Code.
Generated by Claude Code