Skip to content

[access] refactor(interfacing): give BulkSaveSummary, BackendInfo and StateFieldWrite named parts - #7558

Merged
rubenvdlinde merged 1 commit into
mainfrom
cloud/k26-value-objects
Nov 9, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
cloud/k26-value-objects

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K26 (round 10c), SIG unit interfacing P1: value-object constructors above 4 parameters.

What changed

  • BulkSaveSummary (5 → 3): the three row counts become BulkSaveCounts (requested, saved, accounted), built by both bulk-save paths in BulkController.
  • BackendInfo (5 → 3): takes the ProbeResult its reachability, timestamp and latency come from; the hybrid record builds one from the composed atomic records. JSON output unchanged.
  • StateFieldWrite (5 → 3): takes the new and the stored object as StateFieldVersion (data plus the state it is in); null on a create, as before.

Public properties that readers use are unchanged and assigned one by one. StateFieldWrite is on the row/field-level security path: create vs update, edit state and changed-property answers are unchanged (StateFieldRuleListenerTest).

What ran (branch merged with current origin/development)

  • phpunit on every test referencing BulkController, StateField*, AnonymisationBackend*, BackendInfo plus tests/Unit/Service/Anonymisation: 764 tests green
  • guards: tests/Unit/Architecture, Contract, Kernel, Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest: green
  • php -l, phpcs (no errors), phpstan on touched files: clean

Numbers (lane_measure.py, K26 files)

Over-4 units in this PR: 3 constructors (24 LOC) → 0.

AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.


Generated by Claude Code

…ldWrite named parts

BulkSaveSummary takes its three row counts as BulkSaveCounts; BackendInfo
takes the ProbeResult its reachability, timestamp and latency came from;
StateFieldWrite takes the new and the stored object as StateFieldVersion
(data plus the state it is in). The public properties readers use are
unchanged and assigned one by one.

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red here, but not because of this PR.

The job fails the same tests as on the unrelated PRs #7524, #7522, #7528 and #7547:

  • the golden tests JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest, EndpointsControllerAnswersGoldenTest, ProcessingLogServiceGoldenTest, SchemaConfigValidatorsGoldenTest, TextExtractionJobsGoldenTest and SearchReferenceResolverGoldenTest;
  • A18InterfaceBindingsTest, for ObjectRetentionHandler.

None of these covers BulkController, BulkSaveSummary, BackendInfo, AnonymisationBackendService or StateFieldWrite, the classes this PR changes. Those classes' tests (764) and the guard suites passed locally on this branch merged with development. This workflow's last 15 completed runs all failed, across unrelated lanes.

No fix exists to port yet. Per the lane rules this PR gets no further pushes. I have not re-run the job: it fails the same way on other lanes, so this PR is not the cause.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde changed the base branch from development to main November 9, 2026 06:54

Copy link
Copy Markdown
Contributor Author

The ten red quality checks on this PR fail on code that comes from development, not on this PR's change. I checked each job log against the files this PR changes or adds: BulkController, BulkSaveSummary, BulkSaveCounts, BackendInfo, AnonymisationBackendService, StateFieldWrite, StateFieldVersion and StateFieldRuleListener.

Check What fails This PR?
test:l10n / test:l10n:parity / format 14 keys missing from en.js; locales missing two development strings; Prettier on 116 src/ files no, this PR touches nothing in src/ or l10n/
eslint scripts/l10n/*.js no
Frontend Tests (unit) suites refreshButton.spec.js and migrationPackTables.dom.golden.spec.js fail; all 4942 tests pass no JS touched
phpstan the same 24 errors in 12 other files none in this PR's files
phpcs the same 8 other files none in this PR's files
psalm existing files (e.g. ContractBindings.php) none in this PR's files
phpmd 615 findings, the same total as on PRs that don't touch these classes class-level findings on BulkController (length, method count, a static call at line 243) and StateFieldRuleListener (complexity) were already there. This PR adds none; the total is unchanged
Hydra Gates gates 3, 7, 12, 17, 40, 46 and 49, with counts identical to #7522/#7528/#7547 the controller gates count the same as on PRs without BulkController changes

The only other mentions of this PR's files are PSR-4 "Skipping" notices. They come from the existing Unit\… namespaces of those tests, which this PR did not change.

There is no fix to port into this PR. Under the lane rules it takes no further pushes.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 6973897 into main Nov 9, 2026
36 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 32f3aed

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 49035/49045 · 19 skipped
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 16:43 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants