Repository navigation
[access] refactor(interfacing): give BulkSaveSummary, BackendInfo and StateFieldWrite named parts - #7558
Conversation
…ldWrite named parts BulkSaveSummary takes its three row counts as BulkSaveCounts; BackendInfo takes the ProbeResult its reachability, timestamp and latency came from; StateFieldWrite takes the new and the stored object as StateFieldVersion (data plus the state it is in). The public properties readers use are unchanged and assigned one by one. Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red here, but not because of this PR. The job fails the same tests as on the unrelated PRs #7524, #7522, #7528 and #7547:
None of these covers BulkController, BulkSaveSummary, BackendInfo, AnonymisationBackendService or StateFieldWrite, the classes this PR changes. Those classes' tests (764) and the guard suites passed locally on this branch merged with No fix exists to port yet. Per the lane rules this PR gets no further pushes. I have not re-run the job: it fails the same way on other lanes, so this PR is not the cause. Generated by Claude Code |
|
The ten red quality checks on this PR fail on code that comes from
The only other mentions of this PR's files are PSR-4 "Skipping" notices. They come from the existing There is no fix to port into this PR. Under the lane rules it takes no further pushes. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49035/49045 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 16:43 UTC
Download the full PDF report from the workflow artifacts.
Lane K26 (round 10c), SIG unit interfacing P1: value-object constructors above 4 parameters.
What changed
BulkSaveSummary(5 → 3): the three row counts becomeBulkSaveCounts(requested, saved, accounted), built by both bulk-save paths in BulkController.BackendInfo(5 → 3): takes theProbeResultits reachability, timestamp and latency come from; the hybrid record builds one from the composed atomic records. JSON output unchanged.StateFieldWrite(5 → 3): takes the new and the stored object asStateFieldVersion(data plus the state it is in); null on a create, as before.Public properties that readers use are unchanged and assigned one by one. StateFieldWrite is on the row/field-level security path: create vs update, edit state and changed-property answers are unchanged (StateFieldRuleListenerTest).
What ran (branch merged with current origin/development)
Numbers (lane_measure.py, K26 files)
Over-4 units in this PR: 3 constructors (24 LOC) → 0.
AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.
Generated by Claude Code