Repository navigation
[access] refactor(interfacing): bundle seven K26 constructors above four parameters - #7522
Conversation
…viewPolicyResolver and DecisionVisibility constructors Each constructor drops to at most four parameters by moving two or three cohesive collaborators into a final readonly bundle beside the class. Access guards (ObjectActionGate, IGroupManager) stay direct parameters. Assisted-by: ClaudeCode:claude-opus-5-5
…ic page resolver constructors The two schema-scoped providers take their register mapper, schema mapper and logger as one SchemaScopeLookups bundle; the properties the shared SchemaScopedProvider trait reads are still assigned one by one. PublicPageResolver takes its app manager and logger as PublicPageManifests. Assisted-by: ClaudeCode:claude-opus-5-5
…ationsControllerTest Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red here, but not because of this PR. The job reports the same 22 failures and errors as on unrelated PRs (for example #7524):
None of these exercises a class this PR changes: MdtoPreconditions, ObjectActionList, ReviewPolicyResolver, DecisionVisibility, the AppHost schema-scoped providers, or PublicPageResolver. The six golden test files above (not the other two) pass locally on current There is no fix to port yet. Per the lane rules, this PR gets no further pushes. I have not re-run the job: the failures on other lanes already show it isn't this PR. Generated by Claude Code |
|
The Prettier reports "Code style issues found in 116 files" under I haven't ported a fix. Reformatting 116 frontend files belongs in its own change, and under the lane rules this PR gets no further pushes. Generated by Claude Code |
|
This PR changes only PHP under Generated by Claude Code |
|
Jest marks one suite as failed: No fix to port from this PR. Per the lane rules it takes no further pushes. Generated by Claude Code |
|
ESLint flags pre-existing JavaScript, for example This PR has no fix to port, and under the lane rules it takes no further pushes. Generated by Claude Code |
|
PHPStan reports 24 errors, all in files this PR does not touch: None of the files this PR changes or adds is listed: MdtoPreconditions, ObjectActionList, ReviewPolicyResolver, DecisionVisibility, the AppHost providers, PublicPageResolver, and their bundles. Run locally on those files plus the I have no fix to port into this PR, and under the lane rules it takes no further pushes. Generated by Claude Code |
|
Psalm reports errors in 35 files, none of them changed or added by this PR. Examples:
I searched the log for every file this PR changes or adds (MdtoPreconditions/MdtoInputReaders, ObjectActionList/ObjectActionCatalogue, ReviewPolicyResolver/ReviewPolicyFileOwners, DecisionVisibility/DecisionVisibilityPlatform, AbstractSchema*Provider/SchemaScopeLookups, PublicPageResolver/PublicPageManifests) and found no match. The findings come from This PR has no fix to port, and under the lane rules it gets no further pushes. Generated by Claude Code |
|
phpcs reports errors in eight files: The files this PR changes or adds show no phpcs errors, only There's no fix to port into this PR, and under the lane rules it takes no further pushes. Generated by Claude Code |
|
Seven gates fail. Gates 3, 7, 12, 17, 40 and 49 flag controllers, Vue forms and stubs that this PR does not touch (no controller, no Gate 46 (spec-anchor-existence) reports 2 unresolved targets:
Both are already missing on The fix is to point all three files' tags at Generated by Claude Code |
|
phpmd reports 615 findings, all in files this PR does not change. The worst files are No finding names a file this PR changes or adds. The only Edepot hits are in There is no fix to port into this PR, and under the lane rules it takes no further pushes. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 13:41 UTC
Download the full PDF report from the workflow artifacts.
Lane K26 (round 10c), SIG unit interfacing P1: constructors above 4 parameters.
What changed
Seven constructors drop to at most four parameters by moving cohesive collaborators into final readonly bundles beside each class (autowired by DI):
MdtoPreconditionsMdtoInputReaders(source reader, bestand generator, mapping resolver)ObjectActionListObjectActionCatalogue(definitions, inputs); the gate stays directReviewPolicyResolverReviewPolicyFileOwners(root folder, owner lookup)DecisionVisibilityDecisionVisibilityPlatform(event dispatcher, logger);IGroupManagerstays directAbstractSchemaReferenceProviderSchemaScopeLookups(register mapper, schema mapper, logger)AbstractSchemaSearchProviderSchemaScopeLookupsPublicPageResolverPublicPageManifests(app manager, logger)The two schema-scoped providers still assign the private properties the shared
SchemaScopedProvidertrait reads, one by one. Access guards (ObjectActionGate, IGroupManager, IUserSession) stay direct constructor parameters. No allowed/refused outcome changes; every test that builds these classes was updated, existing goldens pass unchanged.What ran (branch merged with current origin/development)
Numbers (lane_measure.py, K26 files)
Over-4 units in this PR: 7 constructors (56 LOC) → 0.
AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.
Generated by Claude Code