Skip to content

[access] refactor(interfacing): bundle seven K26 constructors above four parameters - #7522

Merged
rubenvdlinde merged 3 commits into
mainfrom
cloud/k26-ctor-bundles
Nov 9, 2026
Merged

rubenvdlinde merged 3 commits into
mainfrom
cloud/k26-ctor-bundles

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K26 (round 10c), SIG unit interfacing P1: constructors above 4 parameters.

What changed

Seven constructors drop to at most four parameters by moving cohesive collaborators into final readonly bundles beside each class (autowired by DI):

Class Before After Bundle
MdtoPreconditions 5 3 MdtoInputReaders (source reader, bestand generator, mapping resolver)
ObjectActionList 5 4 ObjectActionCatalogue (definitions, inputs); the gate stays direct
ReviewPolicyResolver 5 4 ReviewPolicyFileOwners (root folder, owner lookup)
DecisionVisibility 5 4 DecisionVisibilityPlatform (event dispatcher, logger); IGroupManager stays direct
AbstractSchemaReferenceProvider 5 3 SchemaScopeLookups (register mapper, schema mapper, logger)
AbstractSchemaSearchProvider 5 3 SchemaScopeLookups
PublicPageResolver 5 4 PublicPageManifests (app manager, logger)

The two schema-scoped providers still assign the private properties the shared SchemaScopedProvider trait reads, one by one. Access guards (ObjectActionGate, IGroupManager, IUserSession) stay direct constructor parameters. No allowed/refused outcome changes; every test that builds these classes was updated, existing goldens pass unchanged.

What ran (branch merged with current origin/development)

  • phpunit on every touched test directory (Edepot, Tmlo*, ObjectAction, Decision, Anonymisation, EntityRelations/DecisionOwnership/GdprEntities controllers, AppHost): green
  • guards: tests/Unit/Architecture, Contract, Kernel, Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest: green
  • php -l, phpcs (no errors; only pre-existing @SPEC warnings), phpstan on touched files (+ the trait): clean

Numbers (lane_measure.py, K26 files)

Over-4 units in this PR: 7 constructors (56 LOC) → 0.

AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.


Generated by Claude Code

…viewPolicyResolver and DecisionVisibility constructors

Each constructor drops to at most four parameters by moving two or three
cohesive collaborators into a final readonly bundle beside the class.
Access guards (ObjectActionGate, IGroupManager) stay direct parameters.

Assisted-by: ClaudeCode:claude-opus-5-5
…ic page resolver constructors

The two schema-scoped providers take their register mapper, schema mapper
and logger as one SchemaScopeLookups bundle; the properties the shared
SchemaScopedProvider trait reads are still assigned one by one.
PublicPageResolver takes its app manager and logger as PublicPageManifests.

Assisted-by: ClaudeCode:claude-opus-5-5
…ationsControllerTest

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red here, but not because of this PR.

The job reports the same 22 failures and errors as on unrelated PRs (for example #7524):

  • the golden tests JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest, EndpointsControllerAnswersGoldenTest, ProcessingLogServiceGoldenTest, SchemaConfigValidatorsGoldenTest, TextExtractionJobsGoldenTest and SearchReferenceResolverGoldenTest;
  • the architecture test A18InterfaceBindingsTest, for ObjectRetentionHandler.

None of these exercises a class this PR changes: MdtoPreconditions, ObjectActionList, ReviewPolicyResolver, DecisionVisibility, the AppHost schema-scoped providers, or PublicPageResolver.

The six golden test files above (not the other two) pass locally on current development, 69 tests. This workflow's last 15 completed runs all failed, across unrelated lanes, so the failure belongs to the job's environment or the base branch.

There is no fix to port yet. Per the lane rules, this PR gets no further pushes. I have not re-run the job: the failures on other lanes already show it isn't this PR.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

The quality / Frontend Check (format) failure isn't caused by this PR.

Prettier reports "Code style issues found in 116 files" under src/ and tests/unit/support/, for example src/views/quality/QualityIndex.vue, src/views/webhooks/WebhooksIndex.vue and tests/unit/support/ncGolden.js. This PR changes only PHP under lib/ and tests/Unit/; it touches no file Prettier checks. Those 116 files arrive unformatted from development.

I haven't ported a fix. Reformatting 116 frontend files belongs in its own change, and under the lane rules this PR gets no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Check (test:l10n) and (test:l10n:parity) fail here, but not because of this PR.

  • test:l10n reports 14 translation keys that are used in src/ but missing from l10n/en.js. The repository's own CLAUDE.md already records test:l10n as red on development (a development merge added keys to src/ without adding them to en.js).
  • test:l10n:parity reports locales such as de and fr missing one key, "We could not count the objects. Close this window and try again.", which was added to en.js on development.

This PR changes only PHP under lib/ and tests/Unit/. It touches nothing in src/ or l10n/. Both gaps arrive from development, and closing them is translation work (the §6.15 procedure), not something that belongs in this PR, which takes no further pushes under the lane rules.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Tests (unit) is red, but this PR doesn't cause it.

Jest marks one suite as failed: src/views/migrationPack/migrationPackTables.dom.golden.spec.js. Every individual test passes (4945 of 4945), so the suite fails at load, outside any single test. This PR changes only PHP under lib/ and tests/Unit/; it touches no JavaScript or Vue file, so the frontend suite runs the same code as on development.

No fix to port from this PR. Per the lane rules it takes no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Vue Quality (eslint) fails here, but not because of this PR.

ESLint flags pre-existing JavaScript, for example scripts/l10n/casing.js and the locale detectors under scripts/l10n/detectors/*.js. This PR changes only PHP under lib/ and tests/Unit/. It touches no .js or .vue file, so the lint findings come unchanged from development.

This PR has no fix to port, and under the lane rules it takes no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpstan) fails here, but not because of this PR.

PHPStan reports 24 errors, all in files this PR does not touch: BackgroundJob/FileTextExtractionJob.php, Controller/EndpointsController.php, Controller/Support/RegisterStatistics.php, Controller/TaskNotesController.php, Controller/WebhooksController.php, Db/Tenancy/TenancyIdentityTrait.php, Notifications/Controller/NotesController.php, Search/Service/GraphQL/GraphQLService.php, Service/Flow/FlowService.php, Service/Import/ImportPreviewService.php, Service/Integration/BuiltinProviders/NotesProvider.php and Service/Task/TaskSequenceService.php ("call to an undefined method", "dead catch").

None of the files this PR changes or adds is listed: MdtoPreconditions, ObjectActionList, ReviewPolicyResolver, DecisionVisibility, the AppHost providers, PublicPageResolver, and their bundles. Run locally on those files plus the SchemaScopedProvider trait, phpstan reports no errors.

I have no fix to port into this PR, and under the lane rules it takes no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (psalm) fails, but not because of this PR.

Psalm reports errors in 35 files, none of them changed or added by this PR. Examples:

  • lib/AppHost/ObservabilityWiring.php
  • lib/Controller/CredentialController.php
  • lib/Db/AuditTrail.php
  • lib/Db/EndpointMapper.php
  • lib/Db/FindLinksByObjectUuidTrait.php (one LessSpecificImplementedReturnType per link mapper)

I searched the log for every file this PR changes or adds (MdtoPreconditions/MdtoInputReaders, ObjectActionList/ObjectActionCatalogue, ReviewPolicyResolver/ReviewPolicyFileOwners, DecisionVisibility/DecisionVisibilityPlatform, AbstractSchema*Provider/SchemaScopeLookups, PublicPageResolver/PublicPageManifests) and found no match. The findings come from development.

This PR has no fix to port, and under the lane rules it gets no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpcs) fails here, but not because of this PR.

phpcs reports errors in eight files: lib/Db/ImportPreviewRow.php, lib/Service/Flow/FlowTokenRouter.php, lib/Service/Object/SaveObject/RelationCascadeHandler.php, lib/Db/RuleRun.php, lib/Db/MagicMapper/MagicObjectSearchInterface.php, lib/Service/ContractBindings.php, lib/Db/CaseItem.php and lib/Db/EntityRelation.php. One example is a line over the 150-character limit. This PR doesn't touch any of them.

The files this PR changes or adds show no phpcs errors, only @spec warnings that were already there. The failures come from development.

There's no fix to port into this PR, and under the lane rules it takes no further pushes.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Hydra Gates is red. Most of it comes from development, but one finding is partly this PR's.

Seven gates fail. Gates 3, 7, 12, 17, 40 and 49 flag controllers, Vue forms and stubs that this PR does not touch (no controller, no .vue file).

Gate 46 (spec-anchor-existence) reports 2 unresolved targets:

  • openspec/changes/schema-scoped-smart-picker/design.md
  • openspec/changes/schema-scoped-smart-picker/specs/schema-scoped-reference-providers/spec.md

Both are already missing on development. The change was archived to openspec/changes/archive/2026-08-17-schema-scoped-smart-picker/, and the existing @spec tags on AbstractSchemaReferenceProvider / AbstractSchemaSearchProvider still point at the old path. But the new lib/AppHost/SchemaScopeLookups.php in this PR copied the broken spec.md anchor, so it adds a tag to an already-dead target. The number of distinct targets doesn't change, and the gate fails on development without this PR too.

The fix is to point all three files' tags at openspec/specs/schema-scoped-reference-providers/spec.md, which exists. Under the lane rules this PR takes no further pushes, so that repair should go in a follow-up (or in the spec-anchor repair already in flight on fix/gate-46-spec-anchor-targets).


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpmd) fails here, but not because of this PR.

phpmd reports 615 findings, all in files this PR does not change. The worst files are lib/Service/OperatorEvaluator.php, lib/Service/Archival/ArchivalNominationService.php, lib/Service/Archival/ArchivalDecisionResolver.php, lib/Db/MagicMapper/MagicCrossTableReaderInterface.php and lib/Mcp/AttributeToolScanner.php.

No finding names a file this PR changes or adds. The only Edepot hits are in MdtoBestandGenerator.php and MdtoEventMapper.php, which this PR does not touch. The PSR-4 notice about MdtoPreconditionsMappingTest comes from that test's existing Unit\Service\Edepot namespace, which this PR did not change.

There is no fix to port into this PR, and under the lane rules it takes no further pushes.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 45003a3 into main Nov 9, 2026
36 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ dda1277

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 13:41 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants