Skip to content

[access] refactor(interfacing): narrow judge, record, HardeningFloorException and ScheduleDescriptor - #7547

Merged
rubenvdlinde merged 4 commits into
mainfrom
cloud/k26-method-params
Nov 9, 2026
Merged

rubenvdlinde merged 4 commits into
mainfrom
cloud/k26-method-params

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K26 (round 10c), SIG unit interfacing P1: methods and constructors above 4 parameters.

What changed

  • DelegationResolver::judge (5 → 4): receives the refusal detail its caller already builds instead of both party names. A characterisation test pinning the refusal detail was committed first, on the old code.
  • HardeningSettingsService::record (5 → 4, private): accepted is derived from whether a refusal was given (?string $refusal = null). Every call site passed accepted: false exactly when it passed a refusal; the audit rows are unchanged (pinned by HardeningSettingsServiceTest).
  • HardeningFloorException::__construct (5 → 2): takes a FloorBreach value (control, floor, proposed, comparator), the same concept the guard's private refusal() sentence now reads (4 → 1). The exception's public readonly properties and toArray() are unchanged.
  • ScheduleDescriptor::__construct (6 → 4): takes ScheduleCadence (interval or cron) and ScheduleCall (action plus arguments); its public properties are unchanged and still assigned one by one. The existing @SuppressWarnings(BooleanArgumentFlag) stays (the enabled flag remains).

Access paths (delegation, hardening) keep their outcomes; checks still run before the operation.

What ran (branch merged with current origin/development)

  • phpunit tests/Unit/Service/Delegation, Service/Hardening, Controller/HardeningControllerTest, AppHost/Scheduling, Repair/ReportUnpublishedSchedulesTest: green
  • guards: tests/Unit/Architecture, Contract, Kernel, Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest: green
  • php -l, phpcs (no errors), phpstan on touched files: clean

Numbers (lane_measure.py, K26 files)

Over-4 units in this PR: 4 (DelegationResolver::judge 19, HardeningSettingsService::record 15, HardeningFloorException::__construct 9, ScheduleDescriptor::__construct 9) → 0.

AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.


Generated by Claude Code

Assisted-by: ClaudeCode:claude-opus-5-5
…tingsService::record and HardeningFloorException

judge() receives the refusal detail its caller already knows instead of
both party names; record() derives accepted from whether a refusal was
given; HardeningFloorException and the guard's refusal sentence share a
FloorBreach value (control, floor, proposed, comparator). Outcomes and
messages are unchanged.

Assisted-by: ClaudeCode:claude-opus-5-5
ScheduleDescriptor takes ScheduleCadence (interval or cron) and
ScheduleCall (action plus arguments); the public properties readers use
are unchanged.

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red here, but not because of this PR.

The job fails on the same tests as on the unrelated PRs #7524, #7522 and #7528:

  • the golden tests JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest, EndpointsControllerAnswersGoldenTest, ProcessingLogServiceGoldenTest, SchemaConfigValidatorsGoldenTest, TextExtractionJobsGoldenTest and SearchReferenceResolverGoldenTest;
  • the architecture test A18InterfaceBindingsTest, for ObjectRetentionHandler.

None of these covers DelegationResolver, the Hardening services or ScheduleDescriptor, which are what this PR changes. The tests for those classes, and the guard suites, passed locally on this branch merged with development. The six failing golden suites also pass locally on current development (69 tests); I did not re-run SearchReferenceResolverGoldenTest or A18InterfaceBindingsTest locally. This workflow's last 15 completed runs all failed, across unrelated lanes.

There is no fix to port yet, and under the lane rules this PR gets no further pushes. I have not re-run the job, because it fails the same way on other lanes, which already rules out this PR.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Three frontend checks fail here: test:l10n, test:l10n:parity and format. This PR does not cause any of them.

  • test:l10n: 14 keys are used in src/ but missing from l10n/en.js. The repository's CLAUDE.md already records this as red on development.
  • test:l10n:parity: some locales lack "We could not count the objects. Close this window and try again." and "Some objects could not be copied.". Both are English strings added on development.
  • format: Prettier reports "Code style issues found in 116 files" under src/ and tests/unit/support/.

This PR changes only PHP under lib/ and tests/Unit/, and touches nothing in src/, l10n/ or any file Prettier checks. The unrelated PRs #7522 and #7528 fail these three checks in exactly the same way.

There is no fix to port into this PR, and under the lane rules it takes no further pushes. The other quality checks on this PR are still running. When they finish, I will check each failure against this PR's own files.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

The remaining red quality checks on this PR are not caused by it either.

Check Result here Same as on unrelated #7522 / #7528
phpstan 24 errors in 12 files (EndpointsController, FlowService, TaskSequenceService, …) yes
psalm errors only in existing files (FindLinksByObjectUuidTrait, CredentialController, AuditTrail, …) yes
phpcs errors in the same 8 files (ImportPreviewRow, FlowTokenRouter, ContractBindings, …) yes
phpmd 615 findings yes
Hydra Gates gates 3, 7, 12, 17, 40, 46 and 49 fail, with counts identical to the other PRs yes
eslint scripts/l10n/*.js yes

I searched each job's log for every file this PR changes or adds: ScheduleCadence, ScheduleCall, ScheduleDescriptor, DelegationResolver, FloorBreach, HardeningFloorException, HardeningFloorGuard, HardeningSettingsService. None appears. The frontend unit tests pass on this PR. Locally, these files are clean under php -l, phpcs (errors) and phpstan, and their tests plus the guard suites pass.

There is no fix to port into this PR. Under the lane rules it takes no further pushes.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 99693e8 into main Nov 9, 2026
37 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ ed6a2bc

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 16:34 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants