Repository navigation
[access] refactor(interfacing): narrow judge, record, HardeningFloorException and ScheduleDescriptor - #7547
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…tingsService::record and HardeningFloorException judge() receives the refusal detail its caller already knows instead of both party names; record() derives accepted from whether a refusal was given; HardeningFloorException and the guard's refusal sentence share a FloorBreach value (control, floor, proposed, comparator). Outcomes and messages are unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
ScheduleDescriptor takes ScheduleCadence (interval or cron) and ScheduleCall (action plus arguments); the public properties readers use are unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red here, but not because of this PR. The job fails on the same tests as on the unrelated PRs #7524, #7522 and #7528:
None of these covers DelegationResolver, the Hardening services or ScheduleDescriptor, which are what this PR changes. The tests for those classes, and the guard suites, passed locally on this branch merged with There is no fix to port yet, and under the lane rules this PR gets no further pushes. I have not re-run the job, because it fails the same way on other lanes, which already rules out this PR. Generated by Claude Code |
|
Three frontend checks fail here:
This PR changes only PHP under There is no fix to port into this PR, and under the lane rules it takes no further pushes. The other quality checks on this PR are still running. When they finish, I will check each failure against this PR's own files. Generated by Claude Code |
|
The remaining red quality checks on this PR are not caused by it either.
I searched each job's log for every file this PR changes or adds: ScheduleCadence, ScheduleCall, ScheduleDescriptor, DelegationResolver, FloorBreach, HardeningFloorException, HardeningFloorGuard, HardeningSettingsService. None appears. The frontend unit tests pass on this PR. Locally, these files are clean under php -l, phpcs (errors) and phpstan, and their tests plus the guard suites pass. There is no fix to port into this PR. Under the lane rules it takes no further pushes. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 16:34 UTC
Download the full PDF report from the workflow artifacts.
Lane K26 (round 10c), SIG unit interfacing P1: methods and constructors above 4 parameters.
What changed
DelegationResolver::judge(5 → 4): receives the refusal detail its caller already builds instead of both party names. A characterisation test pinning the refusal detail was committed first, on the old code.HardeningSettingsService::record(5 → 4, private):acceptedis derived from whether a refusal was given (?string $refusal = null). Every call site passedaccepted: falseexactly when it passed a refusal; the audit rows are unchanged (pinned by HardeningSettingsServiceTest).HardeningFloorException::__construct(5 → 2): takes aFloorBreachvalue (control, floor, proposed, comparator), the same concept the guard's privaterefusal()sentence now reads (4 → 1). The exception's public readonly properties andtoArray()are unchanged.ScheduleDescriptor::__construct(6 → 4): takesScheduleCadence(interval or cron) andScheduleCall(action plus arguments); its public properties are unchanged and still assigned one by one. The existing@SuppressWarnings(BooleanArgumentFlag)stays (theenabledflag remains).Access paths (delegation, hardening) keep their outcomes; checks still run before the operation.
What ran (branch merged with current origin/development)
Numbers (lane_measure.py, K26 files)
Over-4 units in this PR: 4 (DelegationResolver::judge 19, HardeningSettingsService::record 15, HardeningFloorException::__construct 9, ScheduleDescriptor::__construct 9) → 0.
AI disclosure: prepared by Claude Code (claude-opus-5-5) as an automated lane; reviewed by tests only.
Generated by Claude Code