Repository navigation
[access] test(listener): cover the delete/save guards, e-Depot audit log and config type registration - #7555
Conversation
…endar guards branch by branch Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…gistry Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, but not because of this PR. The failures are 11 errors and 11 failures across seven test classes that this PR does not touch:
This PR only adds test files. The same seven classes fail in this workflow on every other open On Generated by Claude Code |
|
The job reports The repository's own Generated by Claude Code |
|
Prettier reports The fix is a repo-wide Generated by Claude Code |
|
Both fixes are in frontend and locale files that belong to other lanes, so I am not widening this test-only PR to make them. No fix exists yet. Generated by Claude Code |
|
The lane rules forbid me from changing production or frontend code in this test-only PR, so I am not fixing either here. No fix exists yet. Generated by Claude Code |
|
The reported errors are in existing production files under The lane rules forbid me from changing production code in this test-only PR. No fix exists yet. Generated by Claude Code |
|
Every psalm error is in existing production files under The lane rules forbid me from changing production code or the baseline in this test-only PR. No fix exists yet. Generated by Claude Code |
|
This was a forced full-repo run ("Forced full-repo run"), so the gates scanned the whole app, not just this diff. The failing gates:
Gates 7, 12, 17, 40 and 49 are about production controllers and Vue files. This PR adds only six PHPUnit test files under For gate 3 and gate 46, the log names only the per-gate log files, not the offending paths, so I could not confirm the location from here. I checked: the six added test files contain no stub markers (no TODO, FIXME, "not implemented" or the like). They also add no new The lane rules forbid me from changing production code in this test-only PR, so I am not fixing these here. No fix exists yet. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49073/49083 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 16:33 UTC
Download the full PDF report from the workflow artifacts.
What this covers
Branch-by-branch PHPUnit tests for eight production classes in lane T02's scope (delete/save guards, the e-Depot transfer audit log, and shareable-config type registration):
Why several of these were at 0 despite existing tests:
phpunit.xmlsetsbeStrictAboutCoverageMetadata="true", so a test that executes a class missing from its@covers/@usesis marked risky and its coverage is dropped (e.g.FrozenObjectDeleteGuardListenerTestexecutesAbstractObjectEntityEventwithout@uses;ConceptDeleteGuardListenerLeavingTestonly exercisesObjectLeavingEvent). The new files list every class they execute and run without risky results. Existing test files are untouched.Each refusal test asserts the exact error payload (code, message, 409 status, detail); each allow path is paired with a refusal that flips the deciding input; fail-open guards assert the logged warning.
What ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --no-progress --coverage-clover /tmp/t02pr1.xml <the 6 new test files>→ OK (38 tests, 101 assertions), thenclover_files.pyon the T02 file list. This is a subset run, so the numbers are a lower bound of the full-suite figure. Weak-test scanner (weak.php) reports none of the new tests. php-cs-fixer applied.Mutation samples (each reverted, never committed)
=== 0->< 0-> 1 test failedreturn $userId->return 'x'-> 1 test failedstopPropagation()-> 2 tests failed=== 0->!== 0-> 2 tests failedsetUser('admin')->setUser('root')-> 1 test failed$this->loaded = true-> 2 tests failedNo production code changed. Tests written with Claude Code.
Generated by Claude Code