Repository navigation
[access] test(tenancy): cover tenant usage, the slug conflict and the reveal audit middleware - #7570
Conversation
…d the reveal audit flush Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, but not because of this PR. The failures are 11 errors and 11 failures across seven test classes that this PR does not touch:
This PR only adds test files (tenancy). The same seven classes fail in this workflow on every other open On Generated by Claude Code |
|
The quality checks that are failing or will fail here are inherited from
I have traced the other quality checks on #7555, which has the same kind of diff (new PHPUnit test files only, under
When these checks fail here the same way, I will not add a comment per check. The details and log excerpts are in the comments on #7555. The lane rules forbid me from changing production, frontend or locale code in a test-only PR. No fix exists yet. Generated by Claude Code |
|
phpmd's findings are all in existing production files under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:33 UTC
Download the full PDF report from the workflow artifacts.
What this covers
PHPUnit tests for three tenancy/audit classes in lane T02's scope:
RevealAuditMiddlewareTest: reveals are flushed after a controller returns and after it throws; the same response / the same exception goes out; a failing flush is logged and never replaces either.TenantUsageSerialisationTest: every field serialised (dates as ISO 8601 in a fixed UTC zone, no clock dependency), a fresh row's zero/null shape, and type hydration from a database row.OrganisationSlugConflictExceptionTest: 409, message, slug and cause.What ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --no-progress --coverage-clover /tmp/t02h.xml <the 3 new test files>→ OK (8 tests, 20 assertions), thenclover_files.pyon the T02 file list (subset run: a lower bound of the full-suite number). Weak-test scanner reports none of the new tests. php-cs-fixer applied.Mutation samples (each reverted, never committed)
afterException-> 2 tests failedformat('c')->format('Y-m-d')-> 1 test failedcode: 409->code: 400-> 1 test failedNo production code changed. Tests written with Claude Code.
Generated by Claude Code