Repository navigation
[access] test(gdpr): cover the locked-note refusal and erasure bucket membership - #7627
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, but not because of this PR. The failures are 11 errors and 11 failures across seven test classes that this PR does not touch:
This PR only adds two test files (locked-note refusal, erasure bucket membership). The same seven classes fail in this workflow on every other open On Generated by Claude Code |
|
The quality checks that are failing or will fail here are inherited from
I have traced the other quality checks on #7555, which has the same kind of diff (new PHPUnit test files only, under
When these checks fail here the same way, I will not add a comment per check. The details and log excerpts are in the comments on #7555. The lane rules forbid me from changing production, frontend or locale code in a test-only PR. No fix exists yet. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 20:36 UTC
Download the full PDF report from the workflow artifacts.
What this covers
isMember), the one CI left uncovered, is now executed; the remaining statements were already covered in CINoteLockedExceptionTest: 423, message, note id and cause.ErasureBucketMembershipTest: the three buckets are members; another case, null, empty and a kind name are not.What ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --no-progress --coverage-clover /tmp/t02z.xml <the 2 new files>→ OK (3 tests, 11 assertions);clover_files.pyon the T02 file list (subset run). Weak-test scanner reports nothing for these files. php-cs-fixer applied.Mutation samples (each reverted, never committed)
return $this->noteId->return 0-> 1 test failedin_array(...)->!in_array(...)-> 2 tests failedNo production code changed. Tests written with Claude Code.
Generated by Claude Code