Skip to content

docs(objects): no closing PHP tag in the counts() doc comment - #5842

Merged
rubenvdlinde merged 1 commit into
developmentfrom
sig/r2-ctl3-counts-doc
Nov 6, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
sig/r2-ctl3-counts-doc

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

<object?> in the doc comment of ObjectsController::counts() holds ?>. lizard ends the PHP block there and reads the rest of the file as HTML, so gate 122 measured 50 of the class's 124 units. The comment now says <object|null>.

No code changes. Gate 122's numbers for ObjectsController get worse once this lands, because 74 units are measured for the first time. Those units were always this size. Other PRs that touch units below counts() need this one first: against a base without it, each touched unit reads as new.

A scan of lib/ found no other comment with this sequence. The only other hits are XML prologs inside strings in OdtWriter.

Checks: gate 122 ratchet 0 findings, 0 changed units.

AI-assisted (Claude Code).

The sequence in `<object?>` ended the PHP block for lizard, so gate 122
read none of the 74 units below counts(). Those units are measured from
here on.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ f482965

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ✅
format ✅
check-schema-l10n ✅
composer ✅ ✅ 165/165
npm ✅ ✅ 640/640
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 34104/34105 · 18 skipped
Newman ❌ 1628/1630
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-06 00:12 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit d912fb7 into development Nov 6, 2026
39 of 49 checks passed
@rubenvdlinde
rubenvdlinde deleted the sig/r2-ctl3-counts-doc branch November 10, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant