Repository navigation
refactor(objects): the bulk validate and vectorization routes in units of 15 lines or fewer - #5856
Merged
Merged
Conversation
The sequence in `<object?>` ended the PHP block for lizard, so gate 122 read none of the 74 units below counts(). Those units are measured from here on. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…s of 15 lines or fewer ValidationWindow carries the register, schema and chunk of a request. Assisted-by: ClaudeCode:claude-opus-5-5
…her Support imports Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 640/640 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 34124/34125 · 18 skipped | ||||
| Newman | ❌ 1628/1630 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-06 00:53 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #5842 first (gate 122 reads these units only from there on).
The bulk routes of
ObjectsControllerin units of at most 15 NLOC.validate()(91 NLOC) reads aSupport\ValidationWindow(register, schema, limit, offset), refuses an incomplete one, and leaves the work tovalidatedChunk(),validationCounts(),validationResponse()andvalidationFailureResponse(). The counts in the log line and in the answer now come from one place.vectorizeBatch()(25) andgetObjectVectorizationStats()(23) only lose their one-key-per-line arrays.Behaviour worth knowing, kept as it is and pinned: the file imports
OCP\DB\Exception, socatch (Exception $e)in these three routes catches database failures only. Any other failure leaves the route.ObjectsControllerBulkRoutesGoldenTest::testOtherFailuresLeaveTheRoutesrecords that. Whether the routes should answer every failure is a separate, visible change.Pinned by
ObjectsControllerBulkRoutesGoldenTest, 19 recorded cases plus that test, on the old code in the first commit, with every parameter read, service call and log line (without file and line). The fixture is unchanged afterwards.Capped mutants: 13 of 13 killed.
Params 3+ in the class: unchanged. All new helpers take at most 2.
Checks: every unit test file naming
ObjectsController(936 tests) under pcov with--fail-on-risky, touched-file phpcs, phpmd, phpstan and psalm clean. Gate 122 ratchet against #5842: 0 findings in 10 changed units. Gate 119: 0.AI-assisted (Claude Code).