Skip to content

refactor(objects): RelationUrlStamper stamps relation records, in units of 15 lines or fewer - #5850

Merged
rubenvdlinde merged 4 commits into
developmentfrom
sig/r2-ctl3-relation-urls
Nov 6, 2026
Merged

rubenvdlinde merged 4 commits into
developmentfrom
sig/r2-ctl3-relation-urls

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Needs #5842 first (gate 122 reads this unit only from there on).

ObjectsController::stampObjectUrls() (57 NLOC, McCabe 15) becomes a one-line call into Support\RelationUrlStamper. Every unit there is at most 15 NLOC, McCabe 5 and 2 params. The record identity travels as one small array, which is also what the deep link resolver receives merged into the row.

Pinned by ObjectsControllerRelationUrlsGoldenTest, 18 cases recorded on the old code in the first commit with every resolver, generator and logger call: no resolver, missing or non-numeric identity, route fallback, no url at all, resolver and generator failures, serializable rows, rows serializing to text and plain objects. The fixture is unchanged afterwards.

Capped mutants: 16 of 16 killed.

Params 3+ in the class: unchanged.

Checks: every unit test file naming ObjectsController (934 tests) under pcov with --fail-on-risky, touched-file phpcs, phpmd, phpstan and psalm clean. Gate 122 ratchet against #5842: 0 findings in 8 changed units. Gate 119: 0.

AI-assisted (Claude Code).

The sequence in `<object?>` ended the PHP block for lizard, so gate 122
read none of the 74 units below counts(). Those units are measured from
here on.

Assisted-by: ClaudeCode:claude-opus-5-5
…ts of 15 lines or fewer

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 3efe1e6

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ✅
format ✅
check-schema-l10n ✅
composer ✅ ✅ 165/165
npm ✅ ✅ 640/640
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 34122/34123 · 18 skipped
Newman ❌ 1628/1630
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-06 00:52 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 980a50b into development Nov 6, 2026
39 of 49 checks passed
@rubenvdlinde
rubenvdlinde deleted the sig/r2-ctl3-relation-urls branch November 10, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant