Repository navigation
feat(rotation): rotation policies, expiry reminders, rotation flags (rotation-expiry-policies) - #76
Merged
Conversation
…otation flags Implements openspec change rotation-expiry-policies: - Migration 22: secrets.expires_at + doriath_expiry_policies + doriath_rotation_flags - RotationPolicyService: effective-expiry resolution (earliest of per-secret, type/folder policies, user override, admin default; server-visible fields only), policy CRUD, idempotent one-open-flag-per-secret lifecycle, mark-rotated only on a proven key_updated_at advance, dismiss, compromise auto-flag - SecretService.setExpiry (owner-only, never touches ciphertext/key age) + flag delete cascade; SuiteCompromiseListener raises suite_compromise flags - ScanExpiringSecretsJob (daily): threshold reminders + overdue policy_expiry flags, notify_security-gated notifications (secret_expiring/secret_rotation_due) - RotationController + routes (expiry get/set, policies, flags, batch-flag IDs-only) - Audit events: secret.expiry_set/rotation_flagged/rotated/rotation_dismissed, policy.expiry_changed (ids/reasons only) - Frontend: RotationPanel on secret detail (expiry editor + chips + flag actions), rotation category + breached batch-flag in health report, dashboard rotation-due KPI, admin Rotation & expiry settings section - Tests: 11 new PHPUnit tests (resolution precedence, proven-advance, batch scope, job threshold/overdue dedupe); fixes pre-existing phpcs/phpstan issues encountered
This was referenced Jul 18, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
rotation-expiry-policiesOpenSpec change.What
expires_atondoriath_secrets; newdoriath_expiry_policies(unique owner/scope/scope_id) anddoriath_rotation_flags(unique secret_id) tables.markRotatedcloses ONLY on a provenkey_updated_atadvance (else re-request path), dismiss, compromise auto-flag.policy_expiryflag + one notification per episode. Gated onnotify_security.PUT /api/v1/secrets/{id}/expiry), expiry-policies CRUD, rotation-flags list/batch (IDs only — no breach verdicts/digests persisted)/rotated/dismiss.rotation_due_count), admin Rotation & expiry settings section.Gates
🤖 Generated with Claude Code