Skip to content

fix(bootstrap): AppHost guard — event listeners were silently never registered - #78

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/bootstrap-listener-guard
Jul 18, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/bootstrap-listener-guard

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Live verification of PR #76 exposed a latent instance-wide defect:

Apps register alphabetically, so doriath registers BEFORE openregister. OCA\OpenRegister\AppHost\Bootstrap was not autoloadable at that moment; the unguarded \Error aborted Application::register() — and every registerEventListener after it silently never ran. Consequence (confirmed in the dev DB): the AuditListener recorded zero dispatched AuditEvents — no share.granted, team_folder.*, attachment.*, or secret.version_restored rows have ever been written; only services that call AuditService::record() directly were audited.

Fix:

  • Include OpenRegister's own composer autoloader when the AppHost class is missing, and wrap Bootstrap::register in try/catch so Doriath's own registrations always run.
  • RotationPolicyService::flag() re-open path now audits like a first raise.
  • Version bump 0.2.12 so occ upgrade processes info.xml background-jobs — the instance had zero Doriath jobs registered; all six now register (verified live, ScanExpiringSecretsJob executed cleanly).

Live-verified after deploy: secret.rotation_flagged/rotation_dismissed/policy.expiry_changed audit rows now record through the dispatcher path.

🤖 Generated with Claude Code

…register; audit flag re-open; bump 0.2.12

- Application::register(): apps register alphabetically, so doriath registered
  BEFORE openregister and OCA\OpenRegister\AppHost\Bootstrap was not yet
  autoloadable. The unguarded \Error aborted register() — EVERY
  registerEventListener after it silently never ran, so the AuditListener
  recorded zero dispatched AuditEvents (shares, attachments, team folders,
  version restores, rotation). Now: include OpenRegister's own composer
  autoloader when the class is missing, and wrap Bootstrap::register in a
  try/catch so Doriath's own registrations always run.
- RotationPolicyService::flag(): the re-open path (resolved flag re-raised)
  now dispatches secret.rotation_flagged like a first raise.
- Version 0.2.12 so occ upgrade processes info.xml background-jobs (the
  instance had ZERO Doriath jobs registered; all six now register, including
  ScanExpiringSecretsJob and the previously-missing PruneSecretVersionsJob).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant