Repository navigation
fix(bootstrap): AppHost guard — event listeners were silently never registered - #78
Merged
Merged
Conversation
…register; audit flag re-open; bump 0.2.12 - Application::register(): apps register alphabetically, so doriath registered BEFORE openregister and OCA\OpenRegister\AppHost\Bootstrap was not yet autoloadable. The unguarded \Error aborted register() — EVERY registerEventListener after it silently never ran, so the AuditListener recorded zero dispatched AuditEvents (shares, attachments, team folders, version restores, rotation). Now: include OpenRegister's own composer autoloader when the class is missing, and wrap Bootstrap::register in a try/catch so Doriath's own registrations always run. - RotationPolicyService::flag(): the re-open path (resolved flag re-raised) now dispatches secret.rotation_flagged like a first raise. - Version 0.2.12 so occ upgrade processes info.xml background-jobs (the instance had ZERO Doriath jobs registered; all six now register, including ScanExpiringSecretsJob and the previously-missing PruneSecretVersionsJob).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live verification of PR #76 exposed a latent instance-wide defect:
Apps register alphabetically, so doriath registers BEFORE openregister.
OCA\OpenRegister\AppHost\Bootstrapwas not autoloadable at that moment; the unguarded\ErrorabortedApplication::register()— and everyregisterEventListenerafter it silently never ran. Consequence (confirmed in the dev DB): the AuditListener recorded zero dispatchedAuditEvents — noshare.granted,team_folder.*,attachment.*, orsecret.version_restoredrows have ever been written; only services that callAuditService::record()directly were audited.Fix:
Bootstrap::registerin try/catch so Doriath's own registrations always run.RotationPolicyService::flag()re-open path now audits like a first raise.occ upgradeprocessesinfo.xmlbackground-jobs — the instance had zero Doriath jobs registered; all six now register (verified live, ScanExpiringSecretsJob executed cleanly).Live-verified after deploy:
secret.rotation_flagged/rotation_dismissed/policy.expiry_changedaudit rows now record through the dispatcher path.🤖 Generated with Claude Code