Skip to content

fix: clear development's own lint, l10n, phpmd and gate failures - #1830

Merged
SudoThijn merged 44 commits into
developmentfrom
fix/development-ci-failures
Nov 18, 2026
Merged

SudoThijn merged 44 commits into
developmentfrom
fix/development-ci-failures

Conversation

@remko48

@remko48 remko48 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Development's CI was red on its own commits, so every branch built on it inherited the failures. This PR fixes them; each commit takes one check. Some checks stay red for reasons outside this change, see Still red below.

Lint, style and formatting

  • The frontend files development merged without Prettier are formatted, including six new e2e workflow specs; in seven of them ESLint and Prettier now agree.
  • Unused imports and catch bindings are removed from the suite store (ESLint).
  • The deprecated word-break: break-word becomes overflow-wrap: anywhere (Stylelint).
  • Three key-proof attributes over 150 characters are wrapped (phpcs).
  • A new check:path-case frontend check refuses two tracked paths that differ only in case (one file on Windows and macOS) or in Unicode normalisation (one file on macOS). A case-only clash lost a spec on this branch.

PHP quality

  • psalm and phpmd: SecretUrlService::normalise() and SecretUpdateController::update() hand parts to helpers to get under the complexity limit, and replaceOnCopies() no longer returns an unused count.
  • phpmd on the privileged-access code development merged: AddressRange validates an address before inet_pton() instead of silencing it, which also turns a 500 on a NUL byte into a refusal, and setPrivileged() drops its else.
  • The privileged-access audit builds its events through AuditEventFactory, created in the constructor body as SecretTrashService does, so no constructor gains a parameter.
  • The remaining coupling, parameter-list, boolean-flag, class-name and named-constructor findings are suppressed with their reasons.

Hydra gates

  • Gate 123 (SIG floor): callers ask AuditMetadataPolicy::isKnown(), and AuditEventTypes drops its now unused isKnown() and policy aliases, so the two classes no longer reference each other.
  • Gate 122: the reprompt switch both secret dialogs held verbatim moves into RepromptSwitch.
  • Gate 7: six endpoints already scope access to the caller in their service or by the signed token assertion, or address no object at all. Each now documents this with the gate's exemption tag. The addGrant tag names the check it still lacks (Attachment grants: check that copySecretId is a copy of the source held by recipientId #1876).
  • Gate 40: TypedFieldsForm binds its label explicitly.
  • Gate 46: the base64 golden's @spec now points at the existing new-device-approval spec, and the website-address tags this PR adds point at openspec/specs/website-addresses/spec.md, since development archived that change.
  • Maintainability floor: formatting development's unformatted files spread JS units over more lines, which dropped unit_size from 4.21 to 4.19. The ten JS units that crossed the 15-line size band now hand part of their work to a named helper (for example readWithParser in the import store, compareStates in versionCompare.js, unwrapWithRecoveryCode in recoveryKit.js), which brings unit_size back to 4.21. Formatting, .maintainability-floor.json and tooling config are unchanged. Closes Recover the unit_size maintainability floor after formatting development #1878.

Tests

  • The SecretMapper golden and the recording database no longer depend on the Nextcloud version: parameter types are recorded by name, and fetchAssociative() (Nextcloud 33+) is only mocked where it exists.
  • The admin settings and address tests declare the classes they now run (strict coverage metadata).
  • The passkey migration test's stand-in table gains setPrimaryKey() and addIndex().
  • The federation provider test is skipped below Nextcloud 33, like the other federation tests.
  • The HealthReportView controls spec mocks the secret store the view now uses.
  • The tests/unit directory leaves the PHPUnit configs; its one test moves to tests/Unit.
  • AddressRangeTest pins the refusal of a NUL byte in a range and in a client address.
  • The three golden-markup specs strip their markup through a shared tests/fixtures/goldenMarkup.js, which repeats the comment strip until the markup stops changing. This clears CodeQL's "incomplete multi-character sanitization" alerts chore(openspec): archive secret-version-history #75 and feat(rotation): rotation policies, expiry reminders, rotation flags (rotation-expiry-policies) #76, which formatting moved so CodeQL counted them as new, and feat(cxf): FIDO Credential Exchange Format import + export (19/19 tasks) #70, which was already open on development. The extension's notice.test.ts strips its <script> the same way, clearing feat(versions): secret version history (19/19 tasks) #74. All snapshots are unchanged.

l10n

  • The seven extension-passkey strings are added to en.json with Dutch translations.
  • The 35 privileged-access and site-directory strings development merged untranslated are added to every required locale, and the browser catalogues are rebuilt.

Still red

  • PHPUnit and Newman fail in "Install Nextcloud" because integriq does not install against the current OpenRegister: its SynchronizationContractProvider::list() uses OpenRegister's newer ObjectRef signature, which OpenRegister's development does not have yet. That is the CI environment, not this change, and development fails the same way. Quality Report fails with them, as it has no coverage report to download.

Follow-ups found in review

🤖 Generated with Claude Code

The format check failed on about 270 source and test files that reached development without Prettier. They are formatted with the repo's config; in seven of them ESLint's top-level-function and multi-line-property rules and Prettier now agree. No behaviour changes.
phpseclib 4.0.2 is affected by GHSA-w3p9-g4p2-h3rr, an unbounded PBKDF iteration count in encrypted key parsing that allows CPU exhaustion, which fails the composer audit. Only the phpseclib entry of the lock changes.
generateKeyPair and importPrivateKey were imported but never used, and two catch clauses named an error they never read.
word-break: break-word is deprecated and fails stylelint; overflow-wrap: anywhere wraps long values the same way.
Three VaultKeyProofRequired attributes were longer than phpcs's 150 characters. They now put one argument per line, as the other long ones already do.
Checking one extra address and building the 403 of a refused update move into helpers, which brings normalise() and update() under the complexity limit. replaceOnCopies() no longer returns a count nobody reads, and the CeremonyStep signature the library fixes is suppressed for psalm as it already was for phpmd. The coupling the website addresses and trusted extension origins added, the list route's query parameters on the service contract and the contract name rule are suppressed with their reasons.
AuditEventTypes is used by 55 classes, so its 288 lines counted towards PHP modules with a fan-in above 50 and pushed that share to 1.9%, over the 1.8% SIG floor. The forbidden keys, the per-type whitelist, the user-referencing keys and isKnown() move to AuditMetadataPolicy, which only the audit and SIEM services read. The share drops to 1.6%; behaviour is unchanged.
Gate 7 sees only the controller body. Attachment upload and grants, the federated share update and link share creation check the caller in their service, the token exchange is authorised by the signed assertion, and the key generator addresses no object. Each now says so with the gate's exemption tag.
The label came in through v-bind, where the form-label gate cannot see it. Both inputs now bind :label directly.
Its @SPEC named openspec/specs/crypto-new-device-approval, which does not exist; the spec is new-device-approval.
…rsion

Older Nextcloud versions pass parameter types as ints and read rows with fetch(), newer ones use enum cases and fetchAssociative(), which only exists from Nextcloud 33. The golden now records types by name and both reads as one, and the recording database mocks fetchAssociative() only where IResult has it.
With strict coverage metadata, PHPUnit fails a test that runs a class it does not list. The admin settings now reach the flow trigger catalogue, site image settings and trusted extension origins, and the address test reaches ForbiddenException.
The table stand-in used below Nextcloud 35 had no setPrimaryKey() or addIndex() for the new challenge table. The federation provider implements an OCM interface of Nextcloud 33, so its test is skipped below that, as the other federation tests are.
The view now uses the secret store to change a login to https, so mounting it without Pinia failed. The spec mocks it as the rendered spec does.
Seven strings of the passkey manager and the extension settings were used in the source but missing from en.json. They are added with their Dutch translations.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ c20a6ec

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
test-l10n ❌
format ❌
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 650/650
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 5257/5257 · 3 skipped (no test failed, the job failed for another reason — see its log)
Newman ✅ 177/177 · 20 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-16 14:42 UTC

Download the full PDF report from the workflow artifacts.

ESLint fails when its suppressions file lists findings that no longer occur. The unused-variable findings in the suite store and an empty block in LinkShareAccess are gone, so their entries are removed.
The formatting pass touched webAddress(), so gate 16 now requires its @SPEC. It builds the address for site previews and for the change-password page, so it names both requirements.
The admin settings now reach the flow trigger catalogue and the site image settings. With strict coverage metadata PHPUnit marked the golden test risky, which failed the stable35 run.
Git tracks both RecipientPicker.spec.js and recipientPicker.spec.js. On Windows they are one file, so the formatting pass could not reach the capitalised one, and the Linux format check flagged it.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 5b6530b

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ❌
format ❌
check-l10n-js ❌
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 650/650
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ✅ 5304/5304 · 3 skipped
Newman ✅ 177/177 · 20 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-16 15:09 UTC

Download the full PDF report from the workflow artifacts.

Every required locale is held to full parity, but 55 strings development merged (site images, website addresses, version compare, flow triggers, vault encryption details, the http-to-https finding) and the 7 extension-passkey strings had no translation outside English and Dutch. They are added to all 35 other locales, using each locale's existing words for vault and passkey, and the browser catalogues are rebuilt.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 6acb7fd

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ❌
check-l10n-js ❌
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 650/650
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ✅ 5304/5304 · 3 skipped
Newman ✅ 177/177 · 20 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-16 15:29 UTC

Download the full PDF report from the workflow artifacts.

Development's platform-properties work added Dutch strings and three unformatted files. Merged with this branch, nl.js was stale and the format check failed; nl.js is rebuilt and the three files are formatted.
…ard it in CI

Linux tracked both tests/components/RecipientPicker.spec.js and recipientPicker.spec.js, and both tests/Unit and tests/unit. On Windows and macOS each pair is one file, so a commit from such a checkout overwrote the lowercase spec with the other one's content. The lowercase spec, a separate suite, is restored from development as RecipientPicker.vaultStatus.spec.js, SettingsControllerTest moves into tests/Unit, and the phpunit configs stop listing tests/unit. check:path-case now fails CI when two tracked paths differ only in case, and its message says how to rename by case only.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 28f4bcc

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 650/650
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ✅ 5304/5304 · 3 skipped
Newman ✅ 177/177 · 20 skipped
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-16 16:16 UTC

Download the full PDF report from the workflow artifacts.

…t-ci-failures

# Conflicts:
#	l10n/be.js
#	l10n/be.json
#	l10n/bg.js
#	l10n/bg.json
#	l10n/bs.js
#	l10n/bs.json
#	l10n/ca.js
#	l10n/ca.json
#	l10n/cs.js
#	l10n/cs.json
#	l10n/da.js
#	l10n/da.json
#	l10n/de.js
#	l10n/de.json
#	l10n/el.js
#	l10n/el.json
#	l10n/en.js
#	l10n/en.json
#	l10n/es.js
#	l10n/es.json
#	l10n/et.js
#	l10n/et.json
#	l10n/fi.js
#	l10n/fi.json
#	l10n/fr.js
#	l10n/fr.json
#	l10n/ga.js
#	l10n/ga.json
#	l10n/hr.js
#	l10n/hr.json
#	l10n/hu.js
#	l10n/hu.json
#	l10n/is.js
#	l10n/is.json
#	l10n/it.js
#	l10n/it.json
#	l10n/lb.js
#	l10n/lb.json
#	l10n/lt.js
#	l10n/lt.json
#	l10n/lv.js
#	l10n/lv.json
#	l10n/mk.js
#	l10n/mk.json
#	l10n/mt.js
#	l10n/mt.json
#	l10n/nb.js
#	l10n/nb.json
#	l10n/nl.js
#	l10n/nl.json
#	l10n/pl.js
#	l10n/pl.json
#	l10n/pt.js
#	l10n/pt.json
#	l10n/rm.js
#	l10n/rm.json
#	l10n/ro.js
#	l10n/ro.json
#	l10n/ru.js
#	l10n/ru.json
#	l10n/sk.js
#	l10n/sk.json
#	l10n/sl.js
#	l10n/sl.json
#	l10n/sq.js
#	l10n/sq.json
#	l10n/sr.js
#	l10n/sr.json
#	l10n/sv.js
#	l10n/sv.json
#	l10n/tr.js
#	l10n/tr.json
#	l10n/uk.js
#	l10n/uk.json
#	lib/Event/Audit/AuditEventTypes.php
#	lib/Event/Audit/AuditMetadataPolicy.php
#	src/components/SecretDetailSidebar.vue
#	src/dialogs/SecretCreateDialog.vue
#	src/export/serializer.js
#	tests/Unit/Controller/ExtensionControllerTest.php
#	tests/dialogs/SecretCreateDialog.clone.spec.js
#	tests/store/health.spec.js
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 15274f7

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ❌
format ❌
check-l10n-js ❌
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-17 10:43 UTC

Download the full PDF report from the workflow artifacts.

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ bd91ea9

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ❌
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 10:58 UTC

Download the full PDF report from the workflow artifacts.

Development merged the privileged-access and site-directory strings with only English and Dutch, so every required locale was 35 keys short and test:l10n failed. They are added to the 35 other locales, reusing each locale's existing words for vault, login, passkey and two-factor, and the browser catalogues are rebuilt.
AddressRange validates an address before inet_pton() instead of silencing its warning, setPrivileged() returns early instead of using else, and both privileged-access audit calls go through AuditEventFactory like every other call site. The remaining coupling, parameter-list, boolean-flag and named-constructor findings are suppressed with their reasons.
AuditEventTypes::isKnown() and the WHITELIST, FORBIDDEN_KEYS and USER_REFERENCING_METADATA_KEYS aliases had no callers left after the policy moved to AuditMetadataPolicy, so the class answered the same question twice. They are removed together with the alias-equality test.
macOS treats the NFC and NFD forms of a name as one file, so the check now normalises to NFC before lowercasing.
Formatting expanded the switch's label into a nine-line block that both dialogs held verbatim, which Hydra gate 122 counts as a new clone. It moves into RepromptSwitch.
The owner check is real, but the body's copySecretId is not yet confirmed to be a copy of the source held by recipientId. The tag says so and points at keepiq#1876.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 7d70f02

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 11:59 UTC

Download the full PDF report from the workflow artifacts.

Injecting AuditEventFactory gave PrivilegedAccessService a ninth and PrivilegedCopyGate an eighth constructor parameter, which Hydra gate 122's parameter ratchet fails. Both record() methods call AuditEvent::forUser() again, with the StaticAccess finding suppressed and its reason given.
The header and the OK message still described a case-only check, and the FAIL message called normalisation clashes a Windows problem; only macOS folds NFC and NFD. A decomposed spelling is now labelled, since both forms print alike.
inet_pton() throws a ValueError on a NUL byte, which surfaced as a 500. packed() now refuses it first; a range and a client address with an embedded NUL byte pin that.
…t-ci-failures

# Conflicts:
#	lib/Db/AccessRequest.php
#	lib/Service/PrivilegedAccess/AccessWindow.php
#	lib/Service/PrivilegedAccess/PrivilegedAccessService.php
Development archived vault-website-addresses, so the three tags this PR added under openspec/changes/vault-website-addresses resolved to nothing. They now name openspec/specs/website-addresses/spec.md, like the other tags on the same requirements.
…ctory

Both record() methods called AuditEvent::forUser() under a suppression whose reason was wrong: the factory needs no constructor parameter. Each class now builds it in its constructor body, as SecretTrashService does, so AuditEventFactory stays the one place that reaches AuditEvent's named constructors and gate 122's parameter counts are unchanged.
Only a flagged create carries the field to the item; the suppression reason said it was stored as-is.
The remedy it printed was case-only. It now says to keep the NFC spelling and git rm the other, and marks any non-NFC spelling as such rather than calling it fully decomposed.
@SudoThijn SudoThijn changed the title fix: make development's own CI checks pass again fix: clear development's own lint, l10n, phpmd and gate failures Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ ec7237d

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ✅
format ❌
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 13:09 UTC

Download the full PDF report from the workflow artifacts.

Six workflow specs from def76e4 and 5e32d5b failed the Prettier check on development and, after the merge, here.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 7d2930c

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 13:33 UTC

Download the full PDF report from the workflow artifacts.

)
console.error(' git mv Old.js tmp.js && git mv tmp.js old.js')
console.error(
"For a normalisation clash, keep the NFC spelling and remove the one marked (not NFC): git rm '<that path>'",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Minor — The normalisation advice fails for a directory clash

The script reports a clash at the shortest clashing path, so when two directory spellings clash it prints the directories (café (not NFC) ↔ café). git rm '<that path>' then refuses with fatal: not removing 'café' recursively without -r. Adding -r would delete every file under the non-NFC directory, including files that exist only there. The console line also drops the "on Linux" qualifier the header comment (lines 36-38) carries.

Impact: developer tooling only; the advice fails closed, but someone who adds -r loses files that have no twin.

Suggested fix: split the advice: for a file, git rm '<that path>'; for a directory, git mv each file into the NFC directory. Add "(on Linux)" to the console line.

Verification: a scratch repo with café/a.js (NFC directory) and café/b.js (NFD directory) → node scripts/check-path-case.js prints • café (not NFC) ↔ café; git rm "<NFD dir>" → fatal: not removing … recursively without -r, exit 128.

SudoThijn
SudoThijn previously approved these changes Nov 17, 2026

@SudoThijn SudoThijn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE (Strict)

All findings from the previous review are addressed, and the follow-ups are tracked in #1876 (attachment grant check) and #1877 (jti replay window). One non-blocking 🟢 remains: the path-case advice for a directory clash.

Approved with a red required check. quality / Hydra Gates fails only on the maintainability floor (unit_size 4.21 → 4.19). Formatting development's unformatted files causes the drop, and #1878 tracks recovering it. Every gate passes, gate 122 included. PHPUnit NC35, Newman and Quality Report fail because integriq cannot be enabled against the current OpenRegister. The two CodeQL alerts are also open on development.

What checks out:

  • Merge with development: the three conflicted files keep this PR's suppressions and development's archived @spec paths. Every @spec tag this PR adds resolves to an existing file and heading.
  • Audit events: the privileged-access audit builds its events through AuditEventFactory again, created in the constructor body, so no constructor gains a parameter.
  • Checks: phpmd, phpcs, phpstan, psalm, test:l10n, format and the other frontend checks pass, and vitest (7163 tests) passes. The PHPUnit unit suite passes apart from one test that needs integriq's dependencies installed.

🤖 Generated with Claude Code

Prettier's line breaks took ten JavaScript units over the 15-line unit_size bound and dropped the maintainability floor from 4.21 to 4.19. Each one now moves part of its work to a helper, which brings it back to 15 lines or fewer without changing behaviour.
CodeQL flags a single-pass regex strip of HTML comments or script blocks as incomplete multi-character sanitization. The golden-markup specs now share tests/fixtures/goldenMarkup.js, and it and the notice test repeat the replace until the markup stops changing, which clears the alerts without changing what the specs compare.
@SudoThijn
SudoThijn merged commit 74c3eb2 into development Nov 18, 2026
13 of 14 checks passed
@SudoThijn
SudoThijn deleted the fix/development-ci-failures branch November 18, 2026 11:29
let out = html
do {
previous = out
out = out.replace(/<script[\s\S]*?<\/script>/g, '')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants